New issue
Advanced search Search tips

Issue 693661 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Launch-OWP
Launch-Accessibility: NA
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: NA
Launch-M-Approved: ----
Launch-M-Target: 58-Dev
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: NA
Launch-UI: NA
Rollout-Type: ----

Blocking:
issue 644889
issue 679176
issue 695202



Sign in to add a comment

Ship IndexedDB 2.0

Project Member Reported by pwnall@chromium.org, Feb 17 2017

Issue description

Change description:
IndexedDB 2.0 introduces a few APIs that optimize some database access patterns and improve programming ergonomics. Chrome will support the full standard by shipping the features below.

Changes to API surface:
* Support for binary keys: https://w3c.github.io/IndexedDB/#key-construct
* IDBObjectStore.prototype.name setter: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-name
* IDBIndex.prototype.name setter: https://w3c.github.io/IndexedDB/#dom-idbindex-name
* IDBObjectStore.prototype.getKey: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
* IDBCursor.prototype.continuePrimaryKey: https://w3c.github.io/IndexedDB/#dom-idbcursor-continueprimarykey

Links:
Public standards discussion: https://github.com/w3c/IndexedDB/issues 

Support in other browsers:
Internet Explorer: No
Firefox: Shipped - https://hacks.mozilla.org/2016/10/whats-new-in-indexeddb-2-0/
Safari: Implemented - https://developer.apple.com/library/prerelease/content/releasenotes/General/WhatsNewInSafari/Articles/Safari_10_1.html

The entire IndexedDB 2.0 API surface is covered by tests that have been upstreamed to web-platform-tests. Our implementation passes all the test cases (159/159). Firefox (nightly) passes over 98.7% (157/159) of the test cases, and Safari (Tech Preview 23) passes over 99.3% (158/159) of the test cases.

We have asked for a TAG review in https://github.com/w3ctag/spec-reviews/issues/153
 
Labels: -M-48
I don't think M48 was the version you intended to add. It shipped more than a year ago.

Comment 3 by jsb...@chromium.org, Feb 21 2017

Labels: M-58

Comment 4 by jsb...@chromium.org, Feb 21 2017

Off by 10. :)

Comment 5 Deleted

Comment 6 by pwnall@chromium.org, Feb 22 2017

Blocking: 695202

Comment 8 by pwnall@chromium.org, Feb 23 2017

#7: Thanks! I was working on the flag flip in http://crrev.com/2706233005, and I was waiting for a CQ dry run to find out which tests I need to update.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/905c681bf73399ab9c462ccf57e9f05640a92277

commit 905c681bf73399ab9c462ccf57e9f05640a92277
Author: pwnall <pwnall@chromium.org>
Date: Fri Feb 24 03:44:06 2017

Ship IndexedDB 2.0.

BUG= 693661 , 644889 

Review-Url: https://codereview.chromium.org/2706233005
Cr-Commit-Position: refs/heads/master@{#452742}

[modify] https://crrev.com/905c681bf73399ab9c462ccf57e9f05640a92277/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/905c681bf73399ab9c462ccf57e9f05640a92277/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/905c681bf73399ab9c462ccf57e9f05640a92277/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/905c681bf73399ab9c462ccf57e9f05640a92277/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/905c681bf73399ab9c462ccf57e9f05640a92277/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[delete] https://crrev.com/f5a506a917f583f5aa6e32231f8a7df563dfe170/third_party/WebKit/LayoutTests/virtual/stable/webexposed/indexeddb-renames-should-not-be-exposed-expected.txt
[delete] https://crrev.com/f5a506a917f583f5aa6e32231f8a7df563dfe170/third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed-expected.txt
[delete] https://crrev.com/f5a506a917f583f5aa6e32231f8a7df563dfe170/third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed.html
[modify] https://crrev.com/905c681bf73399ab9c462ccf57e9f05640a92277/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Status: Fixed (was: Assigned)

Sign in to add a comment