New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693660 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 693659



Sign in to add a comment

Switch to robolectric's version of ShadowGoogleApiAvailability

Project Member Reported by jbudorick@chromium.org, Feb 17 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd

commit 476fddc51fb5cf133f2ce351c6805e65f4cbc4dd
Author: mikecase <mikecase@chromium.org>
Date: Thu Mar 30 22:20:11 2017

Add support for robolectric play-services-shadows.

Adding support to use Robolectric's play-services shadow
classes. Removing a custom shadow class we had in Chromium
now that the same shadow is available in Robolectric.

BUG= 693660 

Review-Url: https://codereview.chromium.org/2760743002
Cr-Commit-Position: refs/heads/master@{#460906}

[modify] https://crrev.com/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd/DEPS
[modify] https://crrev.com/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd/build/android/gyp/write_build_config.py
[modify] https://crrev.com/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd/build/secondary/third_party/android_tools/BUILD.gn
[modify] https://crrev.com/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd/chrome/android/java_sources.gni
[modify] https://crrev.com/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java
[modify] https://crrev.com/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
[delete] https://crrev.com/b6d1b157721d10aebaca323f514ba7d5a09bdcef/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ShadowGoogleApiAvailability.java
[modify] https://crrev.com/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd/chrome/android/webapk/test/BUILD.gn
[modify] https://crrev.com/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd/testing/android/junit/BUILD.gn
[modify] https://crrev.com/476fddc51fb5cf133f2ce351c6805e65f4cbc4dd/third_party/robolectric/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment