Issue 693650 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	wychen@chromium.org
Closed:	May 2017
Cc:	█ k...@chromium.org █ dproctor@google.com wychen@chromium.org
Components:	UI>Browser>AppIndexing
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	1
Type:	Bug
M-58

Blocking:
issue 682077

Entry point of Copyless Paste

Project Member Reported by wychen@chromium.org, Feb 17 2017

Issue description

We need to have:
- Finch control
- Mojo to pump data from renderer to browser
- Entry point around onLoad() event, or right after document has finished parsing.

Comment 1 by wychen@chromium.org, Feb 21 2017

Note to self: URL for end-to-end test:
http://m.huffpost.com/us/entry/us_587b87dde4b09281d0eb5dba

Comment 2 by wychen@chromium.org, Feb 23 2017

Labels: M-58

Comment 3 by wychen@chromium.org, Mar 17 2017

Components: -UI>Browser>Mobile UI>Browser>AppIndexing

Comment 4 by wychen@chromium.org, Apr 4 2017

Note to self: URL for end-to-end test:
https://m.yelp.com/biz/sharetea-palo-alto-2

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a7385630468cde3f9d8ca32204f27592264cb2f

commit 2a7385630468cde3f9d8ca32204f27592264cb2f
Author: wychen <wychen@chromium.org>
Date: Wed Apr 05 07:51:42 2017

Add mojo data types for CopylessPaste

BUG= 693650 

Review-Url: https://codereview.chromium.org/2789313002
Cr-Commit-Position: refs/heads/master@{#462007}

[modify] https://crrev.com/2a7385630468cde3f9d8ca32204f27592264cb2f/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/2a7385630468cde3f9d8ca32204f27592264cb2f/third_party/WebKit/public/platform/modules/document_metadata/OWNERS
[add] https://crrev.com/2a7385630468cde3f9d8ca32204f27592264cb2f/third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/465fa2f3b877316159a8661723bf9a205e09dfe7

commit 465fa2f3b877316159a8661723bf9a205e09dfe7
Author: wychen <wychen@chromium.org>
Date: Fri Apr 07 06:07:58 2017

Move Mojo types to a new namespace

The Mojo type names used in CopylessPaste were too general to be in
namespace blink.mojom.

BUG= 693650 

Review-Url: https://codereview.chromium.org/2803943004
Cr-Commit-Position: refs/heads/master@{#462790}

[modify] https://crrev.com/465fa2f3b877316159a8661723bf9a205e09dfe7/chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java
[modify] https://crrev.com/465fa2f3b877316159a8661723bf9a205e09dfe7/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/465fa2f3b877316159a8661723bf9a205e09dfe7/third_party/WebKit/public/platform/modules/document_metadata/copyless_paste-deprecated.mojom
[modify] https://crrev.com/465fa2f3b877316159a8661723bf9a205e09dfe7/third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0be0df4f013607e35411a085511f7accfef26bbb

commit 0be0df4f013607e35411a085511f7accfef26bbb
Author: wychen <wychen@chromium.org>
Date: Fri Apr 07 10:12:44 2017

Add mojo service for CopylessPaste in Blink

A CopylessPaste mojo service in Blink is added. The parsed data would
be forwarded to the app indexing service.

BUG= 693650 

Review-Url: https://codereview.chromium.org/2787703002
Cr-Commit-Position: refs/heads/master@{#462826}

[modify] https://crrev.com/0be0df4f013607e35411a085511f7accfef26bbb/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/0be0df4f013607e35411a085511f7accfef26bbb/third_party/WebKit/Source/modules/document_metadata/BUILD.gn
[add] https://crrev.com/0be0df4f013607e35411a085511f7accfef26bbb/third_party/WebKit/Source/modules/document_metadata/CopylessPasteServer.cpp
[add] https://crrev.com/0be0df4f013607e35411a085511f7accfef26bbb/third_party/WebKit/Source/modules/document_metadata/CopylessPasteServer.h
[add] https://crrev.com/0be0df4f013607e35411a085511f7accfef26bbb/third_party/WebKit/Source/modules/document_metadata/DEPS
[modify] https://crrev.com/0be0df4f013607e35411a085511f7accfef26bbb/third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/0ef767090d16bd40b7440ff20c6475c77b2f99a8

commit 0ef767090d16bd40b7440ff20c6475c77b2f99a8
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Fri Apr 07 16:56:40 2017

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60d8d102bad145cb66565d6240b85c3115053d4d

commit 60d8d102bad145cb66565d6240b85c3115053d4d
Author: wychen <wychen@chromium.org>
Date: Fri Apr 07 19:23:42 2017

Remove the old mojo type in Copyless Paste

BUG= 693650 

Review-Url: https://codereview.chromium.org/2803823004
Cr-Commit-Position: refs/heads/master@{#462957}

[modify] https://crrev.com/60d8d102bad145cb66565d6240b85c3115053d4d/chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java
[modify] https://crrev.com/60d8d102bad145cb66565d6240b85c3115053d4d/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/4efea4a5a7e3094b722f3454570b0f216101042d/third_party/WebKit/public/platform/modules/document_metadata/copyless_paste-deprecated.mojom

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2212fe7b24c27576a5c8457b8a266cc62d474423

commit 2212fe7b24c27576a5c8457b8a266cc62d474423
Author: wychen <wychen@chromium.org>
Date: Mon Apr 10 10:23:32 2017

Add Finch flag for Copyless Paste

BUG= 693650 

Review-Url: https://codereview.chromium.org/2706363002
Cr-Commit-Position: refs/heads/master@{#463210}

[modify] https://crrev.com/2212fe7b24c27576a5c8457b8a266cc62d474423/chrome/browser/about_flags.cc
[modify] https://crrev.com/2212fe7b24c27576a5c8457b8a266cc62d474423/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/2212fe7b24c27576a5c8457b8a266cc62d474423/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/2212fe7b24c27576a5c8457b8a266cc62d474423/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/2212fe7b24c27576a5c8457b8a266cc62d474423/chrome/common/chrome_features.cc
[modify] https://crrev.com/2212fe7b24c27576a5c8457b8a266cc62d474423/chrome/common/chrome_features.h
[modify] https://crrev.com/2212fe7b24c27576a5c8457b8a266cc62d474423/tools/metrics/histograms/histograms.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/244727d064719e08f022323fecba95ccac5e69c6

commit 244727d064719e08f022323fecba95ccac5e69c6
Author: wychen <wychen@chromium.org>
Date: Mon Apr 10 20:14:57 2017

Trigger Copyless Paste metadata parsing

BUG= 693650 

Review-Url: https://codereview.chromium.org/2802863003
Cr-Commit-Position: refs/heads/master@{#463380}

[add] https://crrev.com/244727d064719e08f022323fecba95ccac5e69c6/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java
[modify] https://crrev.com/244727d064719e08f022323fecba95ccac5e69c6/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/244727d064719e08f022323fecba95ccac5e69c6/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/244727d064719e08f022323fecba95ccac5e69c6/chrome/android/java_sources.gni
[modify] https://crrev.com/244727d064719e08f022323fecba95ccac5e69c6/chrome/browser/chrome_content_renderer_manifest_overlay.json

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0c8c62aa2e7bfbd81d6ec60d0a99ec33d34fae9

commit c0c8c62aa2e7bfbd81d6ec60d0a99ec33d34fae9
Author: wychen <wychen@chromium.org>
Date: Wed Apr 12 02:53:43 2017

Connect CopylessPasteExtractor to CopylessPasteServer

BUG= 693650 

Review-Url: https://codereview.chromium.org/2813003002
Cr-Commit-Position: refs/heads/master@{#463909}

[modify] https://crrev.com/c0c8c62aa2e7bfbd81d6ec60d0a99ec33d34fae9/third_party/WebKit/Source/modules/document_metadata/CopylessPasteServer.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cccac38eeff5383d850ca65039f89b1091cbeeb

commit 9cccac38eeff5383d850ca65039f89b1091cbeeb
Author: dproctor <dproctor@google.com>
Date: Thu Apr 13 22:35:50 2017

Add a cache for recently viewed webpages.

This allows us to avoid re-parsing metadata in certain cases.

BUG= 693650 

Review-Url: https://codereview.chromium.org/2820453002
Cr-Commit-Position: refs/heads/master@{#464577}

[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/BUILD.gn
[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java
[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java
[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/java_sources.gni
[add] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/junit/src/org/chromium/chrome/browser/AppIndexingUtilTest.java

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cccac38eeff5383d850ca65039f89b1091cbeeb

commit 9cccac38eeff5383d850ca65039f89b1091cbeeb
Author: dproctor <dproctor@google.com>
Date: Thu Apr 13 22:35:50 2017

Add a cache for recently viewed webpages.

This allows us to avoid re-parsing metadata in certain cases.

BUG= 693650 

Review-Url: https://codereview.chromium.org/2820453002
Cr-Commit-Position: refs/heads/master@{#464577}

[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/BUILD.gn
[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java
[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java
[modify] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/java_sources.gni
[add] https://crrev.com/9cccac38eeff5383d850ca65039f89b1091cbeeb/chrome/android/junit/src/org/chromium/chrome/browser/AppIndexingUtilTest.java

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/bf181f3213c6f11c3447166e5b5865ed726db456

commit bf181f3213c6f11c3447166e5b5865ed726db456
Author: Devon Proctor <dproctor@google.com>
Date: Fri Apr 14 02:21:29 2017

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12c4f68ae8557ca0af22bbe6281a832e2ed29d9a

commit 12c4f68ae8557ca0af22bbe6281a832e2ed29d9a
Author: wychen <wychen@chromium.org>
Date: Wed Apr 19 01:19:52 2017

Add end-to-end test for CopylessPaste

BUG= 693650 

Review-Url: https://codereview.chromium.org/2819763002
Cr-Commit-Position: refs/heads/master@{#465456}

[modify] https://crrev.com/12c4f68ae8557ca0af22bbe6281a832e2ed29d9a/chrome/android/BUILD.gn
[modify] https://crrev.com/12c4f68ae8557ca0af22bbe6281a832e2ed29d9a/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java
[modify] https://crrev.com/12c4f68ae8557ca0af22bbe6281a832e2ed29d9a/chrome/android/java_sources.gni
[add] https://crrev.com/12c4f68ae8557ca0af22bbe6281a832e2ed29d9a/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java
[add] https://crrev.com/12c4f68ae8557ca0af22bbe6281a832e2ed29d9a/chrome/test/data/android/appindexing/json-ld.html

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46d05bbdf9e2faec3d4ff1d245e380d6eecce774

commit 46d05bbdf9e2faec3d4ff1d245e380d6eecce774
Author: wychen <wychen@chromium.org>
Date: Thu Apr 20 02:07:27 2017

Add UMA for CopylessPaste cache

BUG= 693650 

Review-Url: https://codereview.chromium.org/2826803002
Cr-Commit-Position: refs/heads/master@{#465860}

[modify] https://crrev.com/46d05bbdf9e2faec3d4ff1d245e380d6eecce774/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java
[modify] https://crrev.com/46d05bbdf9e2faec3d4ff1d245e380d6eecce774/chrome/android/junit/src/org/chromium/chrome/browser/AppIndexingUtilTest.java
[modify] https://crrev.com/46d05bbdf9e2faec3d4ff1d245e380d6eecce774/tools/metrics/histograms/histograms.xml

Comment 18 by wychen@chromium.org, Apr 20 2017

We ended up putting the Mojo server inside Blink and put the client in Java. Closing the following two CLs, which is in the other direction (Mojo service in Java, and client in Blink).

Add mojo service for CopylessPaste in Java
https://codereview.chromium.org/2700193002/

Add render frame observer for CopylessPaste
https://codereview.chromium.org/2709893002/

Comment 19 by wychen@chromium.org, May 11 2017

Status: Fixed (was: Started)

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0982cbaa2225d8a7a895aebaaed64be032b418a1

commit 0982cbaa2225d8a7a895aebaaed64be032b418a1
Author: wychen <wychen@chromium.org>
Date: Wed Jul 12 05:10:09 2017

Enable all tests in CopylessPasteTest

The following tests are re-enabled:
- testValid
- testNoMeta
- testCache

All flaky failures in CopylessPasteTest are due to timeout in
CallbackHelper.waitForCallback(). Wait for longer to see if it gets
better.

Reference:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch)&showAllRuns=true&tests=org.chromium.chrome.browser.CopylessPasteTest%23

BUG=713172, 713895 , 713878 , 693650 

Review-Url: https://codereview.chromium.org/2826253004
Cr-Commit-Position: refs/heads/master@{#485865}

[modify] https://crrev.com/0982cbaa2225d8a7a895aebaaed64be032b418a1/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java

►

Issue 693650 link

Issue metadata

Entry point of Copyless Paste

Issue description

Comment 1 by wychen@chromium.org, Feb 21 2017

Comment 1 Deleted

Comment 2 by wychen@chromium.org, Feb 23 2017

Comment 2 Deleted

Comment 3 by wychen@chromium.org, Mar 17 2017

Comment 3 Deleted

Comment 4 by wychen@chromium.org, Apr 4 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Apr 5 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Apr 7 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Apr 7 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Apr 7 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Apr 7 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Apr 10 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Apr 10 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Apr 12 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Apr 13 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Apr 13 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Apr 14 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Apr 19 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Apr 20 2017

Comment 17 Deleted

Comment 18 by wychen@chromium.org, Apr 20 2017

Comment 18 Deleted

Comment 19 by wychen@chromium.org, May 11 2017

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Jul 12 2017

Comment 20 Deleted

Sign in to add a comment