New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693636 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Yesterday
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature

Blocking:
issue 681885



Sign in to add a comment

Universal Links should open sign-in page if user is not signed in

Project Member Reported by jasonkliu@chromium.org, Feb 17 2017

Issue description

If a user is not signed in and clicks a Universal Link, they should be redirected to the sign in page.  Otherwise, they should simply open the app (the current behavior).
 

Comment 1 by sczs@chromium.org, Feb 22 2017

Components: Services>SignIn
Labels: M-59
Owner: msarda@chromium.org
Status: Assigned (was: Untriaged)
Hey Mihai, could you please take a look and let us know if this is a Sign In issue? 

Comment 2 by pkl@chromium.org, Feb 23 2017

Does the sign in page have a chrome:// URL?
Labels: -Pri-3 -M-59 M-58 Pri-2
Friendly ping on this - do we have a chrome:// URL we can redirect to?  Thanks.

Comment 4 by ew...@chromium.org, Mar 8 2017

Cc: ew...@chromium.org
The "Sign in to Chrome" page on iOS doesn't have a chrome:// URL attached to it (AFAIK). It's just a native view in Chrome.

Mihai, can we point the Bling D2M folks to the right place in the code where they can open the sign in screen?
Jason/Peter: What are you guys trying to do? Should the user start a sign-in flow in Chrome at this point and start syncing? If so, then consider using the ChromeSigninViewController (here https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h ).
Owner: jasonkliu@chromium.org

Comment 7 by pkl@chromium.org, Mar 9 2017

Cc: jasonkliu@chromium.org
Components: Mobile>Intents
Labels: -M-58 M-59
Owner: pkl@chromium.org
Users are sent a goo.gl/ioschrome link which expands to a link to iTunes App Store for Chrome app. It is also mapped through universal links to launch Chrome if Chrome is already installed. We currently opens a new tab to NTP when Chrome is launched this way. 

It has been discussed that users who are not signed in should be prompted to sign in when Chrome is launched via a universal link.

I'm taking this from jasonkliu@ since this is probably more of an implementation issue now.
Yes, #7 is correct.

This behavior should be the same (for right now) with both:
goo.gl/ioschrome
goo.gl/ioschrome/* 

Thanks!

Comment 9 by ew...@chromium.org, Mar 9 2017

@#5: yes, the desire is to start the sign-in flow in Chrome so the user can start syncing.
Blocking: 681885
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 12 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by ew...@chromium.org, Apr 12 2017

Status: Assigned (was: Available)

Comment 13 by pkl@chromium.org, Apr 16 2017

Labels: -M-59 M-60
Components: -Mobile>WebView>Glue
Labels: -Type-Bug Type-Feature
Project Member

Comment 15 by sheriffbot@chromium.org, Jun 12 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 16 by ew...@chromium.org, Jun 13 2017

Status: Assigned (was: Available)
Project Member

Comment 17 by sheriffbot@chromium.org, Jul 14 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 18 by ew...@chromium.org, Jul 14 2017

Status: Assigned (was: Available)
Hey Peter, any update on this? I think it'll help close the loop for those users who get the D2M promo on desktop and already have Chrome (they'll be able to sign in and start syncing their data, which is the value prop we pitch in the promo).
Cc: rayraymond@google.com ma...@chromium.org mahmadi@chromium.org
cc: mathp, mahmadi, rayraymond

Would this affect your plans in https://docs.google.com/document/d/1bFro1y1AEGuykaQv-8o9RTwhxFrQ6qSKVz9hH2oNWTw/edit ? If so, maybe we can't make this change. 

Or we would have to whitelist certain Universal Links in the binary, which would be messy.

Comment 20 by ma...@chromium.org, Jul 14 2017

Thanks for thinking of us!

Just to make sure I understand, this is proposing that opening a Universal Link  to Chrome (e.g. goo.gl/ioschrome) would always open the Chrome sign-in page if not signed in? Yes that would certainly affect the plan. 

Perhaps we could have a more specific link such as goo.gl/ioschrome/pay that doesn't have this behavior? It wouldn't be that messy in Chrome iOS code...

Comment 21 by pkl@chromium.org, Jul 15 2017

Having a specific link that is used in the Anchor SMS message sounds like a viable solution.
#20: Do you need only one URL (eg goo.gl/ioschrome/pay), a wildcard (eg goo.gl/ioschrome/pay/*), or some other solution?

per #21: We try different goo.gl variants for each surface, so we would have to whitelist these in the app binary (which shouldn't be hard, we just have 10 total and would maybe only add a few more).  See b/34394541 for the links.

Comment 23 by ma...@chromium.org, Jul 15 2017

One URL would be sufficient.

pkl: Does the whitelist solution in #22 work for you?  That would be fine going forward.
To clarify #24: For each of the whitelisted URLs, the universal link will open the sign-in page.  For any non-whitelisted URL, Chrome should open that URL.

Comment 26 by ew...@chromium.org, Jul 24 2017

Friendly ping. Any chance of getting this into M61 (which just branched), or should we shoot for M62 at this point?

Comment 27 by ew...@chromium.org, Jul 28 2017

Labels: -M-60 M-62
Looks like we missed M61. Peter - is this something you will be able to get to for 62?

Comment 28 by pkl@chromium.org, Jul 28 2017

Labels: -M-62 M-63
Re: the original request of "If a user is not signed in and clicks a Universal Link, they should be redirected to the sign in page.", I have not started working on this and probably won't start early enough for M62.
Project Member

Comment 29 by sheriffbot@chromium.org, Aug 28 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 30 by ew...@chromium.org, Sep 18 2017

Status: Assigned (was: Available)
Hey Peter, just checking in on this again. Branch for 63 is Oct 12. Do you think you'll have this change ready by then?

Comment 31 by pkl@chromium.org, Sep 18 2017

Labels: -M-63
Didn't have time to work on this. Removing milestone label until I do.
Project Member

Comment 32 by sheriffbot@chromium.org, Oct 19 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 33 by ew...@chromium.org, Oct 19 2017

Status: Assigned (was: Available)
Re-marking this as assigned to make sure it doesn't drop off Peter's radar
Cc: ghendel@chromium.org
Project Member

Comment 35 by sheriffbot@chromium.org, Nov 20 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 36 by ew...@chromium.org, Nov 20 2017

Status: Assigned (was: Available)
Keeping as assigned. 64 branch point is next week, FYI.
Project Member

Comment 37 by sheriffbot@chromium.org, Dec 21 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 38 by pkl@chromium.org, Jan 23 2018

Labels: -Pri-2 Pri-3
Owner: ----
Priority lowered because we are putting the Anchor promotions on hold. It may be resumed in the future, and the priority of this may go back up then.
Project Member

Comment 39 by sheriffbot@chromium.org, Yesterday (34 hours ago)

--Chrome Identity automated triaging--

This bug is Available and has gone one year without any activity. If another month passes without any activity, this bug will be closed out. Please provide an update with the latest status for this bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 40 by pkl@chromium.org, Yesterday (30 hours ago)

Status: WontFix (was: Available)
This feature request originated from the goo.gl/ioschrome/. That's no longer being actively developed, so I'm closing this feature request.

Sign in to add a comment