New issue
Advanced search Search tips

Issue 693635 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-02-24
OS: Linux , Android
Pri: 1
Type: Bug



Sign in to add a comment

Card editor (pencil icon) does not select the card's expiration month

Project Member Reported by rouslan@chromium.org, Feb 17 2017

Issue description

Chrome Version       : Canary
OS Version: Android 7.1.2

What steps will reproduce the problem?
1. Edit (in PaymentRequest) a local card with non-January expiration month.

What is the expected result?
The expiration month in editor should be populated based on the card.

What happens instead of that?
The expiration month is always January.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Screencast: https://drive.google.com/open?id=0BwnAxYoFTeYPZ3dqbFhIMS1VaDA

 
Labels: -M-58 M-57
Labels: -M-57 M-56
Actually happens even on Stable. If the fix is small, let's merge to M-57. No need to merge to M-56.
Labels: -Type-Bug-Regression Type-Bug
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d0ee9842f3600ac4fb3489c2ea6bafd85d6dee8

commit 3d0ee9842f3600ac4fb3489c2ea6bafd85d6dee8
Author: gogerald <gogerald@chromium.org>
Date: Wed Feb 22 01:09:55 2017

Format expiration month dropdown key format to the stored format in Autofill

July is formatted to 07 instead of 7

BUG= 693635 

Review-Url: https://codereview.chromium.org/2708183002
Cr-Commit-Position: refs/heads/master@{#451863}

[modify] https://crrev.com/3d0ee9842f3600ac4fb3489c2ea6bafd85d6dee8/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java

Labels: M-57 Merge-Request-57
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 22 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
If possible, could you please merge your change to M57 branch 2987 by 5:00 PM PT tomorrow, Wednesday (02/22) so we can pick it up for this week beta release. 
Thank you.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 22 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d55d96620d8d9b7ed4decef78b1313681c71ab86

commit d55d96620d8d9b7ed4decef78b1313681c71ab86
Author: gogerald <gogerald@google.com>
Date: Wed Feb 22 14:25:04 2017

Format expiration month dropdown key format to the stored format in Autofill

July is formatted to 07 instead of 7

BUG= 693635 

Review-Url: https://codereview.chromium.org/2708183002
Cr-Commit-Position: refs/heads/master@{#451863}
(cherry picked from commit 3d0ee9842f3600ac4fb3489c2ea6bafd85d6dee8)

Review-Url: https://codereview.chromium.org/2709103003 .
Cr-Commit-Position: refs/branch-heads/2987@{#641}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/d55d96620d8d9b7ed4decef78b1313681c71ab86/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java

Labels: -M-56
Status: Fixed (was: Assigned)
I think we are not intend to merge it to M56 since it is in stable now, so close this bug after merging M57. 
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment