Compilation failure on Android Perf Builders in vulcanize_gn.py |
|||
Issue descriptionThis CL appears to be causing compilation failures on the Android Perf Builders. This is the error I am seeing.... Link: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20arm64%20Compile/builds/12251 python ../../chrome/browser/resources/vulcanize_gn.py --host md-settings --html_in_file settings.html --html_out_file vulcanized.html --js_out_file crisper.js --input gen/chrome/browser/resources/settings/settings_resources.pak --out_folder gen/chrome/browser/resources/settings --depfile gen/chrome/browser/resources/settings/vulcanize.d --insert_in_head \<base\ href=\"chrome://\$i18n{hostname}\"\> Traceback (most recent call last): File "../../chrome/browser/resources/vulcanize_gn.py", line 217, in <module> main(sys.argv[1:]) File "../../chrome/browser/resources/vulcanize_gn.py", line 208, in main unpack_pak.unpack(args.input, output_folder) File "/b/build/slave/Android_arm64_Compile/build/src/chrome/browser/resources/unpack_pak.py", line 34, in unpack assert resource_ids AssertionError Looks like this CL is responsible: https://codereview.chromium.org/2573943002
,
Feb 17 2017
,
Feb 17 2017
@dbeam: I am wondering why MD Settings vulcanize target is running on Android Perf builders, it makes little sense to me.
,
Feb 17 2017
Issue 693562 has been merged into this issue.
,
Feb 17 2017
FYI, https://codereview.chromium.org/2696763003/ fixes the build config to not unnecessarily build MD Settings on Android.
,
Feb 17 2017
fwiw: the CL was reverted and it did fix
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb1a92c477c4dc2f72fdbeaa28b09b632cd928da commit fb1a92c477c4dc2f72fdbeaa28b09b632cd928da Author: agrieve <agrieve@chromium.org> Date: Fri Feb 17 23:38:12 2017 Don't build chrome://settings on Android It already wasn't being included via repack(), so this just stops it from being built in the first place BUG= 673825 , 693619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2696763003 Cr-Commit-Position: refs/heads/master@{#451398} [modify] https://crrev.com/fb1a92c477c4dc2f72fdbeaa28b09b632cd928da/chrome/BUILD.gn [modify] https://crrev.com/fb1a92c477c4dc2f72fdbeaa28b09b632cd928da/chrome/browser/BUILD.gn [modify] https://crrev.com/fb1a92c477c4dc2f72fdbeaa28b09b632cd928da/chrome/browser/resources/BUILD.gn |
|||
►
Sign in to add a comment |
|||
Comment 1 by mikec...@chromium.org
, Feb 17 2017