Issue metadata
Sign in to add a comment
|
Missing new tab title |
||||||||||||||||||||||
Issue descriptionApp Version: 57.0.2987.56 beta iOS Version: 10.3, 9.3.5 Device: iPad mini2, iPhone6 URL: new tab page Steps to reproduce: 1. Launch Google Chrome 2. Open a new tab 3. (on iPhone) Enter tab switcher Observed results: chrome://newtab is displayed as new tab title Expected results: "New Tab" should be displayed as new tab title Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M56 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M57 Yes Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKuWWd6M096X095aGM/view
,
Feb 22 2017
This is working fine on ToT and Canary 58.0.3020.0, so it seems to be only broken on the M57 branch. srikanthg: Would it be possible to bisect when this was fixed to narrow down the search for which CLs need to be cherry-picked? Thanks.
,
Feb 22 2017
Good Version: 56.0.2987.54 #e483b04 Bad Version: 56.0.2987.55 #8a3e905
,
Feb 22 2017
,
Feb 22 2017
I mean 57.* not 56.*
,
Feb 23 2017
Sorry for not clarifying, I was looking to bisect when the bug was fixed, not when it was introduced, since it is working correctly on ToT and the latest canary.
,
Feb 23 2017
,
Feb 23 2017
This was caused by bad cherry-pick. Turns out I cherry picked CL wrong CL, which was later reverted. This is missing part: https://codereview.chromium.org/2691693002/diff2/1:20001/ios/web/web_state/ui/crw_web_controller.mm
,
Feb 23 2017
Fix on review: https://codereview.chromium.org/2711123004/
,
Feb 24 2017
Fixed on Branch
,
Feb 24 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 24 2017
,
Mar 1 2017
Verified on latest chrome beta 57.0.2987.85 on iPhone 5(9.3.5) and iPad4(10.2.1) and "New Tab" is displayed as new tab title |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sczs@chromium.org
, Feb 22 2017Labels: ReleaseBlock-Stable M-57
Owner: kkhorimoto@chromium.org
Status: Assigned (was: Untriaged)