New issue
Advanced search Search tips

Issue 693591 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Feb 2017
Cc:
mard...@chromium.org
olivierrobin@chromium.org
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ReadingList entries are not marked as seen when dismissing with accessibility

Project Member Reported by gambard@chromium.org, Feb 17 2017 
What steps will reproduce the problem?
(1) Add one item to ReadingList
(2) Open Reading List
(3) Close Reading List using the escape gesture or the bluetooth keyboard's escape key

What is the expected result?
The entries should have been marked as "seens" and the reading list button in the tool menu should be black.

What happens instead?
"Reading List" in toolmenu is blue
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6299cc1d8fc24c3fd382b6dbe615a58381b73af0

commit 6299cc1d8fc24c3fd382b6dbe615a58381b73af0
Author: gambard <gambard@chromium.org>
Date: Tue Feb 21 13:06:03 2017

Create ReadingListCoordinator

This CL creates a ReadingListCoordinator, to manage the ViewController.

BUG= 688392 ,  693591 

Review-Url: https://codereview.chromium.org/2693863005
Cr-Commit-Position: refs/heads/master@{#451747}

[modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h
[modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
[add] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_coordinator.h
[add] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm
[rename] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm
[modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h
[modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
[delete] https://crrev.com/ad615573268058885e7e43a15196e5936dc6237f/ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.h
[delete] https://crrev.com/ad615573268058885e7e43a15196e5936dc6237f/ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.mm

Comment 2 by gambard@chromium.org, Feb 21 2017

Status: Fixed (was: Assigned)

Comment 3 by pmadalla@chromium.org, Feb 28 2017

Status: Verified (was: Fixed)
Verified the issue in the 58.0.3026.0 canary tested on iPhone(iOS10) and iPad(9.3.5 & iOS 10).
Menu icon in reading list turns to black  on dismissing the reading list menu in accessibility mode and with bluetooth keyboard.works fine
►

Sign in to add a comment