Create matcher for settings back button |
||
Issue descriptionThere should be a common matcher for the settings back button. It relies upon "ic_arrow_back", and it being a button. This is used multiple time in EG tests, and would make it more readable to have a matcher for this.
,
Jul 12 2017
Hey Yuke, sorry for not updating this. The matcher is already created (SettingsBackButton()). There is at least one EG test that uses it, so that should be cleaned up. Sorry for the confusion. If you want to finish it, go ahead. If not, flip it to me.
,
Jul 12 2017
Not a problem, yeah, I already saw that, I'm cleaning the egtests up, and will close the bug once it's landed.
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/018138b898b40be1a269e2061f4dfe18ea493c8c commit 018138b898b40be1a269e2061f4dfe18ea493c8c Author: Yuke Liao <liaoyuke@chromium.org> Date: Wed Jul 12 18:03:46 2017 Use SettingsMenuBackButton in PasswordsSettingsTestCase. This CL re-factors PasswordsSettingsTestCase to use chrome_test_util::SettingsMenuBackButton() and removes the local helper. Bug: 693589 Change-Id: Ied40101d92b74562ae700cef7f2c39628af3303b Reviewed-on: https://chromium-review.googlesource.com/567245 Reviewed-by: Louis Romero <lpromero@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486023} [modify] https://crrev.com/018138b898b40be1a269e2061f4dfe18ea493c8c/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
,
Jul 12 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by liaoyuke@chromium.org
, Jul 12 2017Owner: liaoyuke@chromium.org
Status: Started (was: Available)