Replace AssertCookieExists and AssertNoCookieExists with a method that returns BOOL |
||||
Issue descriptionTo make the code simpler and make it more clear in the test what the assertion is, it would be nice in settings_egtest to remove Assert[No]CookieExists, with a method that returns BOOL. Then the callsite in the test can perform the assert and provide whatever error message they desire.
,
Feb 17 2017
I'll take this one.
,
Feb 17 2017
You should wait for this review to land until you do the fix: https://codereview.chromium.org/2661473004/ No rush, I just want to make sure we don't do conflicting work. Thanks!
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5dbb7a7fe2cf1b9086f1f7a88082e998705086f commit e5dbb7a7fe2cf1b9086f1f7a88082e998705086f Author: liaoyuke <liaoyuke@chromium.org> Date: Tue Mar 14 22:36:39 2017 Refactor Assert[No]CookieExists to return a boolean Instead of asserting inside helper functions, this CL refactors Assert[NO]CookieExists functions to return a boolean value and have the test asserts explicitly. This not only makes the intention of the functions more clear but also allows more flexible handling of the error, such as wrap it inside a wait condition or customize error message etc. BUG= 693580 Review-Url: https://codereview.chromium.org/2734963004 Cr-Commit-Position: refs/heads/master@{#456868} [modify] https://crrev.com/e5dbb7a7fe2cf1b9086f1f7a88082e998705086f/ios/chrome/browser/net/cookies_egtest.mm [modify] https://crrev.com/e5dbb7a7fe2cf1b9086f1f7a88082e998705086f/ios/chrome/browser/ui/settings/settings_egtest.mm [modify] https://crrev.com/e5dbb7a7fe2cf1b9086f1f7a88082e998705086f/ios/chrome/test/earl_grey/chrome_earl_grey.h [modify] https://crrev.com/e5dbb7a7fe2cf1b9086f1f7a88082e998705086f/ios/chrome/test/earl_grey/chrome_earl_grey.mm
,
Mar 14 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by baxley@chromium.org
, Feb 17 2017