New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693579 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Create matcher for IDS_IOS_NAVIGATION_BAR_DONE_BUTTON

Project Member Reported by baxley@chromium.org, Feb 17 2017

Issue description

This string is used close to 50 times in various matchers.

There should be a common matcher in chrome_matchers.h/mm to handle this.
 

Comment 1 by baxley@chromium.org, Feb 17 2017

Cc: linds...@chromium.org
Labels: Proj-EarlGrey
Owner: baxley@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba2952ea9150740fdeca13c3c973aaa1310a09de

commit ba2952ea9150740fdeca13c3c973aaa1310a09de
Author: baxley <baxley@chromium.org>
Date: Tue Mar 07 18:11:27 2017

Create shared matcher for navigation bar done button.

Update tests to use shared matcher, rather than implementing
their own.

BUG= 693579 

Review-Url: https://codereview.chromium.org/2733973002
Cr-Commit-Position: refs/heads/master@{#455134}

[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/browser/ui/keyboard_commands_egtest.mm
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/browser/ui/settings/block_popups_egtest.mm
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/browser/ui/settings/translate_ui_egtest.mm
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/test/earl_grey/chrome_matchers.h
[modify] https://crrev.com/ba2952ea9150740fdeca13c3c973aaa1310a09de/ios/chrome/test/earl_grey/chrome_matchers.mm

Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/5cc54fecf1868de68bca472aed94e1bbee975962

commit 5cc54fecf1868de68bca472aed94e1bbee975962
Author: baxley <baxley@google.com>
Date: Tue May 09 02:01:24 2017

Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85edb5c8cb4d700870cff49f11d133be7c64d10a

commit 85edb5c8cb4d700870cff49f11d133be7c64d10a
Author: baxley <baxley@chromium.org>
Date: Tue May 09 04:38:27 2017

Use NavigationBarDoneButton() matcher in EarlGrey tests.

Some tests were using the IDS label, when there is a matcher to make
it simpler. Also, cleanup some C-style calls wrapping EarlGrey methods.

BUG= 693579 

Review-Url: https://codereview.chromium.org/2861243002
Cr-Commit-Position: refs/heads/master@{#470214}

[modify] https://crrev.com/85edb5c8cb4d700870cff49f11d133be7c64d10a/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
[modify] https://crrev.com/85edb5c8cb4d700870cff49f11d133be7c64d10a/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/85edb5c8cb4d700870cff49f11d133be7c64d10a/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm

Status: Fixed (was: Started)

Sign in to add a comment