New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 693569 link

Starred by 1 user
Status: Fixed
Owner:
█ fsam...@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
danakj@chromium.org
█ staraz@chromium.org
samans@chromium.org
rjkroege@chromium.org
vmp...@chromium.org
kylec...@chromium.org
enne@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GpuDisplayCompositorFrameSink => GpuRootCompositorFrameSink

Project Member Reported by fsam...@chromium.org, Feb 17 2017 
I wanted to record my conversation with Dana in a bug somewhere before I forget. GpuDisplayCompositorFrameSink, and GpuOffscreenCompositorFrameSink are a bit of a misnomer.

Both are "onscreen" in the sense that their content will be displayed on screen at some point. What might make more sense is calling the root CompositorFrameSink that holds a cc::Display, GpuRootCompositorFrameSink, and call the child GpuCompositorFrameSink.

GpuRootCompositorFrameSink != a derived class of GpuCompositorFrameSink though because the Root holds an associated interface to MojoCompositorFrameSink.

That's OK, DisplayCompositor can simply hold a map to MojoCompositorFrameSink*.

Comment 1 by fsam...@chromium.org, Feb 22 2017

Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)
I'll take care of this one.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77b4ea5b3c861be061f8f498d42ad9f63c55e82f

commit 77b4ea5b3c861be061f8f498d42ad9f63c55e82f
Author: fsamuel <fsamuel@chromium.org>
Date: Fri Feb 24 02:51:43 2017

GpuDisplayCompositorFrameSink => GpuRootCompositorFrameSink

GpuDisplayCompositorFrameSink, and GpuOffscreenCompositorFrameSink are
a bit of a misnomer. Both are "onscreen" in the sense that their
content will be displayed on screen at some point. This CL renames
GpuDisplayCompositorFrameSink to GpuRootCompositorFrameSink, and the
child CompositorFrameSinks, GpuCompositorFrameSink.

GpuRootCompositorFrameSink != a derived class of GpuCompositorFrameSink
though because the Root holds an associated interface to
MojoCompositorFrameSink.

Finally, this CL also updates display_compositor.mojom to match the new
naming.

BUG= 693569 
TBR=tsepez@chromium.org for rename in display_compositor.mojom
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2710703005
Cr-Commit-Position: refs/heads/master@{#452725}

[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/cc/ipc/display_compositor.mojom
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/components/display_compositor/BUILD.gn
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/components/display_compositor/gpu_compositor_frame_sink.cc
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/components/display_compositor/gpu_compositor_frame_sink.h
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/components/display_compositor/gpu_compositor_frame_sink_delegate.h
[delete] https://crrev.com/36fa76db42e1543599371dd2d5cb2c32bcee39f2/components/display_compositor/gpu_display_compositor_frame_sink.cc
[delete] https://crrev.com/36fa76db42e1543599371dd2d5cb2c32bcee39f2/components/display_compositor/gpu_display_compositor_frame_sink.h
[delete] https://crrev.com/36fa76db42e1543599371dd2d5cb2c32bcee39f2/components/display_compositor/gpu_offscreen_compositor_frame_sink.cc
[delete] https://crrev.com/36fa76db42e1543599371dd2d5cb2c32bcee39f2/components/display_compositor/gpu_offscreen_compositor_frame_sink.h
[add] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/components/display_compositor/gpu_root_compositor_frame_sink.cc
[add] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/components/display_compositor/gpu_root_compositor_frame_sink.h
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/services/ui/surfaces/display_compositor.cc
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/services/ui/surfaces/display_compositor.h
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/services/ui/ws/server_window.cc
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/services/ui/ws/server_window.h
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/services/ui/ws/server_window_compositor_frame_sink_manager.cc
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/services/ui/ws/server_window_compositor_frame_sink_manager.h
[modify] https://crrev.com/77b4ea5b3c861be061f8f498d42ad9f63c55e82f/services/ui/ws/window_tree.cc

Comment 3 by fsam...@chromium.org, Feb 25 2017

Status: Fixed (was: Assigned)

Comment 4 by fsam...@chromium.org, Jun 13 2017

Blocking: -601863

Comment 5 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService
►

Sign in to add a comment