New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693568 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue skia:7298



Sign in to add a comment

Layout test virtual/gpu/fast/canvas/canvas-imageSmoothingQuality.html failing on Mac

Project Member Reported by zakerinasab@chromium.org, Feb 17 2017

Issue description

The layout test virtual/gpu/fast/canvas/canvas-imageSmoothingQuality.html is failing reliably on linux, mac and win trybots (see trybot results in https://codereview.chromium.org/2679083003/#ps40001).

This bug was discovered when refactoring the layout test to use testharness.js instead of js-test.js.
 

Comment 1 by junov@chromium.org, Feb 27 2017

Owner: zakerinasab@chromium.org
Status: Assigned (was: Untriaged)
Owner: xidac...@chromium.org
Owner: zakerinasab@chromium.org
According to the flakiness dashboard, the test is now passing on Linux and Win, but still failing on Mac trybots:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-imageSmoothingQuality.html
The problem with this test on Mac is that the test expects medium and high quality filters to produce the same result, but the result must be different from low quality filter. On Mac, it seems that generating the mipmaps fail, and all filter qualities fall back to low, hence failing the test.

Since there is already a pixel version of this test (fast/canvas/canvas-imageSmoothingQuality-pixel.html), there is no more to do here except updating TestExpectations. We keep this bug open for a periodic check to see when the root cause is solved in Skia.
Blockedon: skia:7298
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/837057b3271bfd9244e2a38a513867ace41ad536

commit 837057b3271bfd9244e2a38a513867ace41ad536
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Nov 14 17:18:19 2017

Update canvas-imageSmoothingQuality.html layout test fail status

According to the flakiness dashboard, layout test virtual/gpu/fast/canvas/
canvas-imageSmoothingQuality.html is now passing on Linux and Win, but still
failing on Mac trybots:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-imageSmoothingQuality.html

This CL updates the fail tag to reflect this behavior.

Bug:  693568 
Change-Id: Ibd2974c9c02706d0ad5d6b0c342e2dc1112ead34
TBR: junov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/768948
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516338}
[modify] https://crrev.com/837057b3271bfd9244e2a38a513867ace41ad536/third_party/WebKit/LayoutTests/TestExpectations

Summary: Layout test virtual/gpu/fast/canvas/canvas-imageSmoothingQuality.html failing on Mac (was: Layout test virtual/gpu/fast/canvas/canvas-imageSmoothingQuality.html failing on all platforms)
This test is still flaking on Linux.

On linux_chromium_rel_ng it has been 5% of the last 100 failures: 
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8b12920e8c2042e47816d004b113c155e81aee

commit fa8b12920e8c2042e47816d004b113c155e81aee
Author: Alexis Hetu <sugoi@google.com>
Date: Fri Jul 06 14:14:32 2018

Attempt to unmark some tests as slow/timeout

Now that SwiftShader is on Linux/Windows/MacOS and that a recent
performance improvement has been landed in SwiftShader, verify
which tests still require the Slow/Timeout markers and which don't.

TBR=kbr@chromium.org

Bug:chromium:24182  chromium:433711  chromium:763197  chromium:311482   chromium:243871   chromium:664857   chromium:9798   chromium:237270   chromium:241576   chromium:241869   chromium:246749   chromium:535478   chromium:363029   chromium:364225   chromium:552556   chromium:570656   chromium:584807  chromium:614910  chromium:791659   chromium:726075   chromium:808153  chromium:816045  chromium:693568  chromium:626703 chromium:703533 chromium:786641  chromium:799137   chromium:831686   chromium:831230  chromium:818324  chromium:810437   chromium:847205  chromium:848799  chromium:828962   chromium:849284   chromium:855055 

Change-Id: I5d36d20bd87b234fefe4da3ea7e4af039c0188cb
Reviewed-on: https://chromium-review.googlesource.com/1102341
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572962}
[modify] https://crrev.com/fa8b12920e8c2042e47816d004b113c155e81aee/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/fa8b12920e8c2042e47816d004b113c155e81aee/third_party/WebKit/LayoutTests/TestExpectations

Cc: -junov@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment