New issue
Advanced search Search tips

Issue 693566 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

SurfaceIdAllocator => LocalSurfaceIdAllocator

Project Member Reported by fsam...@chromium.org, Feb 17 2017

Issue description

With FrameSinkIdAllocator on its way to landing soon (see https://codereview.chromium.org/2691363002/), "SurfaceIdAllocator" is a bit of a misnomer. It's really a LocalSurfaceIdAllocator as it doesn't touch (or care about) the FrameSinkId. I think we should rename SurfaceIdAllocator to LocalSurfaceIdAllocator for consistency.

In the future, when SurfaceIds are allocated in the parent, the parent will actually have a LocalSurfaceIdAllocator as the FrameSinkId for the child remains fixed.
 

Comment 1 by ericrk@chromium.org, Feb 22 2017

Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a9aa94c031851e8e19eac0ac30e2ae25cc61136

commit 1a9aa94c031851e8e19eac0ac30e2ae25cc61136
Author: xing.xu <xing.xu@intel.com>
Date: Thu Feb 23 21:04:32 2017

Rename SurfaceIdAllocator to LocalSurfaceIdAllocator

BUG= 693566 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2708153005
Cr-Commit-Position: refs/heads/master@{#452626}

[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/android_webview/browser/hardware_renderer.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/android_webview/browser/surfaces_instance.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/BUILD.gn
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/direct_compositor_frame_sink.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/direct_compositor_frame_sink.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/direct_compositor_frame_sink_unittest.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/display_unittest.cc
[add] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/local_surface_id_allocator.cc
[add] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/local_surface_id_allocator.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/surface.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/surface_aggregator_unittest.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/surface_hittest_unittest.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/surface_id.h
[delete] https://crrev.com/930324f05148191a536e4500d9b492c059a4771e/cc/surfaces/surface_id_allocator.cc
[delete] https://crrev.com/930324f05148191a536e4500d9b492c059a4771e/cc/surfaces/surface_id_allocator.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/surface_manager.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/surface_unittest.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/surfaces/surfaces_pixeltest.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/components/exo/surface.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/components/exo/surface.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/compositor/image_transport_factory.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/compositor/surface_utils.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/renderer_host/offscreen_canvas_surface_impl.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/renderer/android/synchronous_compositor_frame_sink.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/content/renderer/android/synchronous_compositor_frame_sink.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/services/ui/public/cpp/window_compositor_frame_sink.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/services/ui/ws/frame_generator.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/ui/aura/mus/DEPS
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/ui/compositor/compositor.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/ui/compositor/compositor_unittest.cc
[modify] https://crrev.com/1a9aa94c031851e8e19eac0ac30e2ae25cc61136/ui/compositor/test/in_process_context_factory.cc

Owner: xing...@intel.com
Status: Fixed (was: Untriaged)
Blocking: -601863
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment