Issue metadata
Sign in to add a comment
|
line length limit is too restrictive |
||||||||||||||||||||||
Issue descriptionThe v8 team is about to switch from Rietveld to Gerrit. I find Gerrit's current limit (in the configuration we use) regarding the line length of commit title and message too restrictive: remote: (W) 80f5690: commit subject >65 characters; use shorter first paragraph remote: (W) 80f5690: too many commit message lines longer than 70 characters; manually wrap lines (Also, why does it not give me a chance to fix that?) Most of us probably use a limit of 80 in our editor as that's what we use in our code and as far as I can tell it's also what Rietveld accepted. Is there any chance to stick to 80?
,
Feb 21 2017
When git opens your editor to edit a commit message, it passes the git commit message filetype. Your editor can be configured to recognize that filetype at impose a shorter column limit (my vim automatically sets 72). The most widely accepted format is actually stricter: it's called the 50/72 rule. https://medium.com/@preslavrachev/what-s-with-the-50-72-rule-8a906f61f09c#.d6ymoihhg chromium/src mostly abides by this as well, with the plurality of commit messages having 50 characters, and the significant majority having 72 or fewer. Given that gerrit a) only returns a warning, not an error b) has a looser limit (65 characters instead of 50) I'd say that we have no intent of changing this. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by andyb...@chromium.org
, Feb 21 2017Status: Assigned (was: Untriaged)