Expose thread stacks memory in the memory-infra metric |
||
Issue descriptionBackground context: Internal thread "Did we regress stack sizes? Do we have benchmarks for that?" Today we have information about stack size in memory-infra, yet don't surface it at a metric level. I never expected thread stacks to contribute in any meaningful manner to memory usage. At the same time, thinking more, exposing it might be a very easy task at least on Linux/Android. The information we need today is stored in the memory maps, and grouped under Total->Stack So this would be more a matter of adding that to https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/metrics/system_health/memory_metric.html?rcl=36a50828018d37783cb7259e57b2510b38e085ce&l=734 +ajwong,erikchen for the Windows/OSX. No idea if/how to get that information there. I looked at the fresh OSX mmaps, but I don't see anything explicitly marked as "stack". maybe on osx they are just anonymous segments? In the meantime assigning to perezju@. Not high prio, but at the same time is probably a O(hour) thingy
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b31521864a0cdd5dbf600c4dbd575005392113b commit 9b31521864a0cdd5dbf600c4dbd575005392113b Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Mon Feb 27 10:34:48 2017 Roll src/third_party/catapult/ 47b98570f..456b3a552 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/47b98570f6e8..456b3a55214e $ git log 47b98570f..456b3a552 --date=short --no-merges --format='%ad %ae %s' 2017-02-27 perezju [tracing] Expose thread stacks memory in memory-infra metric Created with: roll-dep src/third_party/catapult BUG= 693558 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2718983003 Cr-Commit-Position: refs/heads/master@{#453181} [modify] https://crrev.com/9b31521864a0cdd5dbf600c4dbd575005392113b/DEPS
,
Sep 20 2017
This looks done. |
||
►
Sign in to add a comment |
||
Comment 1 by perezju@chromium.org
, Feb 20 2017