New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693527 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 701355
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

34.5% regression in smoothness.key_mobile_sites_smooth at 450940:450978

Project Member Reported by alexclarke@chromium.org, Feb 17 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=693527

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-NyPqwsM


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 17 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : smoothness.key_mobile_sites_smooth
  Metric       : input_event_latency_discrepancy/input_event_latency_discrepancy

Suspected Commit Range
  20 commits in range
  https://chromium.googlesource.com/chromium/src/+log/04ff52bb66284467ccb43d90800013b89ee8db75..9b5580df750abd8c3354d7c63e8a7d38c479ea39


Revision             Result                  N
chromium@450939      338.721 +- 34.9174      6        good
chromium@450940      ---                     ---      build failure
---                  ---                     ---      too many build failures to list
chromium@450958      ---                     ---      build failure
chromium@450959      392.672 +- 71.8308      6        bad
chromium@450978      403.435 +- 71.9683      6        bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests smoothness.key_mobile_sites_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987407107310904992

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5302513860870144


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Feb 23 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : smoothness.key_mobile_sites_smooth
  Metric       : input_event_latency_discrepancy/input_event_latency_discrepancy

Suspected Commit Range
  10 commits in range
  https://chromium.googlesource.com/chromium/src/+log/2c9d42be25e5cf9da980a3a83c376ba40a0764d9..9b5580df750abd8c3354d7c63e8a7d38c479ea39


Revision             Result                  N
chromium@450939      339.496 +- 68.4061      6        good
chromium@450949      330.361 +- 19.9019      6        good
chromium@450950      ---                     ---      build failure
chromium@450951      ---                     ---      build failure
chromium@450952      ---                     ---      build failure
chromium@450953      ---                     ---      build failure
chromium@450954      ---                     ---      build failure
chromium@450955      ---                     ---      build failure
chromium@450956      ---                     ---      build failure
chromium@450957      ---                     ---      build failure
chromium@450958      ---                     ---      build failure
chromium@450959      390.536 +- 42.7734      6        bad
chromium@450978      402.601 +- 30.0776      6        bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests smoothness.key_mobile_sites_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8986924840631040032

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5871449279037440


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 6 by ericrk@chromium.org, Feb 23 2017

Components: Blink
Owner: yigu@chromium.org
Status: Assigned (was: Untriaged)
Looking at the suspect range, I'm suspecting:

https://codereview.chromium.org/2700613002, which seems related to scrolling

yigu@, can you take a look?
Components: -Blink Blink>Scroll
Labels: Hotlist-ThreadedRendering

Comment 8 by yigu@chromium.org, Feb 24 2017

I've added a patch regarding this issue. Not sure whether or not my previous CL caused the problem. Let's see how it goes when the new CL gets landed.

Comment 9 by yigu@chromium.org, Feb 24 2017

Hi alexclarke@, after discussing with bokan@, I think there is a high chance that the regression was caused by other patches (V8 and Skia related patch). Running try bitsect now but please ask other people to look into this issue as well.

Comment 10 by yigu@chromium.org, Feb 24 2017

Owner: ----
Status: Available (was: Assigned)
try success for buildbucket @ rd314595d0dec1082132d26e1887b6c5b7de3005d
Build: 4644 on android_nexus5_perf_bisect
slave: build99-b4
issue: 2716723003
raw patchset: 1
Labels: Performance-Responsiveness
Owner: yigu@chromium.org
Yi - can you confirm if this was your change or not? If not, please reassign to Alex and remove Hotlist-ThreadedRendering

Comment 14 by yigu@chromium.org, Mar 15 2017

Labels: -Hotlist-ThreadedRendering
Owner: ericrk@chromium.org

Comment 15 by yigu@chromium.org, Mar 20 2017

Cc: ericrk@chromium.org
Owner: yigu@chromium.org
Status: Started (was: Available)

Comment 16 by yigu@chromium.org, Mar 21 2017

Mergedinto: 701355
Status: Duplicate (was: Started)

Sign in to add a comment