New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693525 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 850138

Blocking:
issue 696537



Sign in to add a comment

Improve the Incognito New Tab Page

Project Member Reported by msramek@chromium.org, Feb 17 2017

Issue description

This bug tracks the implementation of the visual and text improvements of the Incognito New Tab Page.

Specs: https://folio.googleplex.com/incognito-redesign/

 
Labels: -OS-All OS-Chrome OS-Linux OS-Mac OS-Windows
This is not for mobile is it? Adjusting OS accordingly.
Labels: -OS-Linux -OS-Windows -OS-Chrome -OS-Mac OS-All
The plan is to update the page on all platforms.

The folder linked in #0 currently doesn't show mobile specs, but they should be added soon.

Blocking: 696537
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfe102adddc5a18fc2cc6c453e5342450895aa4b

commit cfe102adddc5a18fc2cc6c453e5342450895aa4b
Author: msramek <msramek@chromium.org>
Date: Mon Feb 27 19:13:46 2017

Add strings to be used on the new version of Incognito NTP.

- Title
- Subtitle
- Disclaimer
- Two lists of bulletpoints

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

The UI where the strings will be used is not a part of this CL.

BUG= 693525 

Review-Url: https://codereview.chromium.org/2703733004
Cr-Commit-Position: refs/heads/master@{#453285}

[modify] https://crrev.com/cfe102adddc5a18fc2cc6c453e5342450895aa4b/components/new_or_sad_tab_strings.grdp

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfe102adddc5a18fc2cc6c453e5342450895aa4b

commit cfe102adddc5a18fc2cc6c453e5342450895aa4b
Author: msramek <msramek@chromium.org>
Date: Mon Feb 27 19:13:46 2017

Add strings to be used on the new version of Incognito NTP.

- Title
- Subtitle
- Disclaimer
- Two lists of bulletpoints

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

The UI where the strings will be used is not a part of this CL.

BUG= 693525 

Review-Url: https://codereview.chromium.org/2703733004
Cr-Commit-Position: refs/heads/master@{#453285}

[modify] https://crrev.com/cfe102adddc5a18fc2cc6c453e5342450895aa4b/components/new_or_sad_tab_strings.grdp

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ca3ccf74e804e13da4c622177f6fc6787019c1e

commit 7ca3ccf74e804e13da4c622177f6fc6787019c1e
Author: msramek <msramek@chromium.org>
Date: Wed Mar 29 19:48:07 2017

Refine the strings on the Incognito NTP and improve the descriptions

BUG= 693525 

Review-Url: https://codereview.chromium.org/2774293002
Cr-Commit-Position: refs/heads/master@{#460500}

[modify] https://crrev.com/7ca3ccf74e804e13da4c622177f6fc6787019c1e/components/new_or_sad_tab_strings.grdp

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7cf9f66afb5f63cee9465a8b4056d7ca7edd853

commit e7cf9f66afb5f63cee9465a8b4056d7ca7edd853
Author: msramek <msramek@chromium.org>
Date: Thu Apr 20 08:38:07 2017

Added a bulletpoint about autofill data to the Incognito NTP

TBR=sdefresne@chromium.org
BUG= 693525 

Review-Url: https://codereview.chromium.org/2822253006
Cr-Commit-Position: refs/heads/master@{#465952}

[modify] https://crrev.com/e7cf9f66afb5f63cee9465a8b4056d7ca7edd853/components/new_or_sad_tab_strings.grdp

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8443118aa963ba364ee9687b82d1d9c7eb26af5

commit a8443118aa963ba364ee9687b82d1d9c7eb26af5
Author: msramek <msramek@chromium.org>
Date: Mon Apr 24 23:20:10 2017

Revamp the Incognito NTP on Desktop

Changes in this CL:

1. Added an about:flag for the "MD Incognito NTP". (Note that the primary
purpose of this change is to improve the text on the Incognito NTP, not
just to materialize it; but the latter results in a shorter flag name and
thematically fits with the other recent MD improvements).

2. Since almost none of the old CSS is valid for the new MD, and since
there are also related HTML changes, we use separate HTML and CSS files.
NTPResourceCache decides which one to serve according to the flag. Once
this fully launches, we will simply remove the previous implementation.

3. The new design follows the CSS rules described in
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI.
The requirement that the two sets of bulletpoints determine the width of
the content box has been achieved by JS (the CSS is complicated enough as
it is :-( ).

Tested with the bookmark bar on/off, with a custom theme on/off, and in
front of a UX designer :)

BUG= 693525 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2804823002
Cr-Commit-Position: refs/heads/master@{#466817}

[modify] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/browser/about_flags.cc
[modify] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/browser/browser_resources.grd
[modify] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/browser/flag_descriptions.h
[add] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/browser/resources/ntp4/md_incognito_tab.css
[add] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/browser/resources/ntp4/md_incognito_tab.html
[add] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/browser/resources/ntp4/md_incognito_tab.js
[modify] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
[modify] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/common/chrome_features.cc
[modify] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/chrome/common/chrome_features.h
[modify] https://crrev.com/a8443118aa963ba364ee9687b82d1d9c7eb26af5/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cff2db73be7698c664ddbcf0625d4cb5b6f9246c

commit cff2db73be7698c664ddbcf0625d4cb5b6f9246c
Author: msramek <msramek@chromium.org>
Date: Tue Apr 25 12:32:56 2017

Mark the new Incognito NTP strings as translateable

...since they have been finalized by now.

TBR=sdefresne@chromium.org
BUG= 693525 

Review-Url: https://codereview.chromium.org/2835053004
Cr-Commit-Position: refs/heads/master@{#466954}

[modify] https://crrev.com/cff2db73be7698c664ddbcf0625d4cb5b6f9246c/components/new_or_sad_tab_strings.grdp

Project Member

Comment 10 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c61cbbb6d255c2a846deaf9e3979843c5756b1b

commit 4c61cbbb6d255c2a846deaf9e3979843c5756b1b
Author: msramek <msramek@chromium.org>
Date: Wed May 10 12:49:35 2017

Small CSS improvements on the new Incognito NTP

1. The rgb() colors expressing X% white are replaced with rgba() colors
   expressing 100% white with X% opacity. Since the background is not
   completely black (0% white), this makes the text color slightly lighter.

2. The 16px/24px vertical offsets are replaced with 1rem/1.5rem. This
   means no functional change for the default font size of 16px, but the
   paragraph spacing looks better for nondefault sizes.

BUG= 693525 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873573003
Cr-Commit-Position: refs/heads/master@{#470543}

[modify] https://crrev.com/4c61cbbb6d255c2a846deaf9e3979843c5756b1b/chrome/browser/resources/ntp4/md_incognito_tab.css

Screenshots of the CL https://codereview.chromium.org/2902013002/ (Android version WIP):


incognito_sketch_1.png
134 KB View Download
incognito_sketch_2.png
134 KB View Download
Project Member

Comment 12 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe9fc5308c333d5dd084872675cff77ff87c894c

commit fe9fc5308c333d5dd084872675cff77ff87c894c
Author: msramek <msramek@chromium.org>
Date: Wed May 24 17:47:28 2017

Fix the MD Incognito NTP background color regression

The CL https://codereview.chromium.org/2891983003/ intended to fix the white
flash while loading Incognito NTP by moving the color definition from CSS
to ThemeProperties. Unfortunately, the approach had two problems:

1. The color in ThemeService can be overriden in the NTPResourceCache to
   SkColor(0x32, 0x32, 0x32). However, the new MD Incognito NTP uses
   SkColor(0x30, 0x30, 0x30) (which used to be defined in the CSS), which
   creates a visible seam between the background and the content area.

2. The color definition in ThemeProperties is not always reached. ThemeService
   can route the query to CustomThemeSupplier. For example, on Linux, the
   request may be answered by SystemThemeX11, which has no concept of
   Incognito, and thus always returns the default (white) background color.
   This means that the white flash issue is not solved.

This CL only addresses the problem 1.

BUG= 693525 

Review-Url: https://codereview.chromium.org/2899053002
Cr-Commit-Position: refs/heads/master@{#474343}

[modify] https://crrev.com/fe9fc5308c333d5dd084872675cff77ff87c894c/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/fe9fc5308c333d5dd084872675cff77ff87c894c/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Project Member

Comment 13 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acd48bf956b4bf7de6702c20ebdbe83132a2be8c

commit acd48bf956b4bf7de6702c20ebdbe83132a2be8c
Author: msramek <msramek@chromium.org>
Date: Wed May 24 19:10:09 2017

Implement a sketch of the new MD Incognito NTP on Android

This CL introduces:
- A feature flag for the new Incognito NTP on Android
- A new FrameLayout for this page (XML + Java)
- Reuses the HTML-formatted strings from the new Desktop Incognito NTP

The CL only contains structural changes; it is not yet styled to match
the spec (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI)

BUG= 693525 

Review-Url: https://codereview.chromium.org/2902013002
Cr-Commit-Position: refs/heads/master@{#474381}

[add] https://crrev.com/acd48bf956b4bf7de6702c20ebdbe83132a2be8c/chrome/android/java/res/layout/new_tab_page_incognito_md.xml
[modify] https://crrev.com/acd48bf956b4bf7de6702c20ebdbe83132a2be8c/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/acd48bf956b4bf7de6702c20ebdbe83132a2be8c/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/acd48bf956b4bf7de6702c20ebdbe83132a2be8c/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
[add] https://crrev.com/acd48bf956b4bf7de6702c20ebdbe83132a2be8c/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java
[modify] https://crrev.com/acd48bf956b4bf7de6702c20ebdbe83132a2be8c/chrome/android/java_sources.gni
[modify] https://crrev.com/acd48bf956b4bf7de6702c20ebdbe83132a2be8c/chrome/browser/about_flags.cc
[modify] https://crrev.com/acd48bf956b4bf7de6702c20ebdbe83132a2be8c/chrome/browser/android/chrome_feature_list.cc

Project Member

Comment 14 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8852f2672df3b8c9f1daeadbcee5243191de8f5

commit a8852f2672df3b8c9f1daeadbcee5243191de8f5
Author: msramek <msramek@chromium.org>
Date: Wed May 24 19:17:21 2017

Enable the new Incognito NTP

It was developed behind an experimental flag, but has been finished and
approved by the UI review. This CL still leaves the flag in until the
feature is fully launched, for easy disabling if necessary.

BUG= 693525 

Review-Url: https://codereview.chromium.org/2902843002
Cr-Commit-Position: refs/heads/master@{#474384}

[modify] https://crrev.com/a8852f2672df3b8c9f1daeadbcee5243191de8f5/chrome/common/chrome_features.cc

Project Member

Comment 15 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81064bed1ae35ec03307b6d7ffee8336386429b1

commit 81064bed1ae35ec03307b6d7ffee8336386429b1
Author: msramek <msramek@chromium.org>
Date: Thu May 25 04:12:32 2017

Refresh the Incognito NTP layout on default font size change

The maximum width of the Incognito NTP content is not described by CSS,
but computed by JS as a function of the font size. Therefore, it must
be recomputed on font size changes.

BUG= 693525 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2905433002
Cr-Commit-Position: refs/heads/master@{#474546}

[modify] https://crrev.com/81064bed1ae35ec03307b6d7ffee8336386429b1/chrome/browser/resources/ntp4/md_incognito_tab.css
[modify] https://crrev.com/81064bed1ae35ec03307b6d7ffee8336386429b1/chrome/browser/resources/ntp4/md_incognito_tab.js
[modify] https://crrev.com/81064bed1ae35ec03307b6d7ffee8336386429b1/chrome/browser/ui/webui/ntp/new_tab_ui.cc
[modify] https://crrev.com/81064bed1ae35ec03307b6d7ffee8336386429b1/chrome/browser/ui/webui/ntp/new_tab_ui.h

Screenshots of https://codereview.chromium.org/2933903002/ (with highlighted layout).
incognito-narrow-1.png
173 KB View Download
incognito-narrow-2.png
175 KB View Download
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42b293e0d826de47c6ecd71774a41f1be37143eb

commit 42b293e0d826de47c6ecd71774a41f1be37143eb
Author: msramek <msramek@chromium.org>
Date: Tue Jun 13 12:58:31 2017

Make the narrow version of the Android Incognito NTP follow the spec

This CL contains improvements of the new Incognito NTP on Android.

1. Bulletpoints: Added the bulletpoint symbol (U+2022), stripped extra
   leading and trailing whitespace.

2. Layout: Updated layout gravity, color, line spacing in the XML file.
   The rest of the layout depends on the tab size, and is thus generated
   programatically in onMeasure().

After these changes, the narrow (width <= 720dp) versions of the NTP
match the spec:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI/files/MCGdLyvs6-fT_lDwU79t-Y5B

This CL does NOT yet contain the wide screen layout (width > 720dp)
which places the two sets of bulletpoints next to each other.

BUG= 693525 

Review-Url: https://codereview.chromium.org/2933903002
Cr-Commit-Position: refs/heads/master@{#478989}

[modify] https://crrev.com/42b293e0d826de47c6ecd71774a41f1be37143eb/chrome/android/java/res/layout/new_tab_page_incognito_md.xml
[modify] https://crrev.com/42b293e0d826de47c6ecd71774a41f1be37143eb/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java

Cc: msrchandra@chromium.org
Labels: Needs-Feedback
Tested the issue on Latest Dev# 61.0.3135.4 on Windows, Mac and Linux (Desktop versions) and observed the following items present in the Incognito Window. Attached a screenshot.

Could some one please look into it and update whether this is the required version.
Thanks in Advance.
693525.png
45.4 KB View Download
Labels: -Needs-Feedback
Re #18: Your screenshot shows the new Incognito NTP, and looks correctly. However, I'm not sure what you mean by required version. If you mean required for feature launch testing, this is covered in issue 696537 (which targets M60).
Android implementation screenshot as of https://codereview.chromium.org/2963523002/
Incognito-wide.png
104 KB View Download
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c65e5b86d2530a035bf17612b2e12109c942d878

commit c65e5b86d2530a035bf17612b2e12109c942d878
Author: msramek <msramek@chromium.org>
Date: Fri Jun 30 14:20:07 2017

Additional improvements of the new Incognito NTP

Changes in this CL:
1. Remove the lighter font from the title and subtitle (this is
   a leftover from the previous NTP).

2. Remove the trailing newline after the third bulletpoint. This made
   the bottom margin artificially larger.

3. Move the layout code from the onMeasure() to the onLayout() phase
   where it semantically belongs. Additionally, call
   setLayoutParams() after changing LayoutParams of a View (otherwise
   the change would not be registered).

4. If the screen is wide and the two sets of bulletpoints together
   are not too wide, arrange them next to each other by wrapping
   them in a linear layout.

5. If the bulletpoints are arranged next to each other, make the
   subtitle width equal to them. NOTE: The first layout pass calculates
   the width incorrectly by 10dp. I am still not sure why, so this is
   fixed in a hacky way for now.

6. Remove the ternary rule for padding-bottom (32/48/72 dp) in favor
   of a simpler binary one (32/72 dp) after feedback from the UX.

7. Resolve the TODO about the icon size (fortunately, it's a no-op).

BUG= 693525 

Review-Url: https://codereview.chromium.org/2963523002
Cr-Commit-Position: refs/heads/master@{#483694}

[modify] https://crrev.com/c65e5b86d2530a035bf17612b2e12109c942d878/chrome/android/java/res/layout/new_tab_page_incognito_md.xml
[modify] https://crrev.com/c65e5b86d2530a035bf17612b2e12109c942d878/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9828df63fe8ba13923c6ee9133fd7584b7dd3fc0

commit 9828df63fe8ba13923c6ee9133fd7584b7dd3fc0
Author: msramek <msramek@chromium.org>
Date: Fri Jun 30 16:10:45 2017

Improve the "Learn more" link on the Incognito New Tab page.

The "Learn more" link is a standalone element on a narrow (<= 720dp)
screen, but is a part of the subtitle on a wide (> 720dp) screen.

This is achieved by showing/hiding the standalone element and
including/removing a ClickableSpan in the subtitle.

Currently, none of the "Learn more" links has any visual response to
clicking (e.g. highlight), which is consistent with other such
links in Chrome's native UI. However, it could be added in the future.

BUG= 693525 

Review-Url: https://codereview.chromium.org/2968483002
Cr-Commit-Position: refs/heads/master@{#483722}

[modify] https://crrev.com/9828df63fe8ba13923c6ee9133fd7584b7dd3fc0/chrome/android/java/res/layout/new_tab_page_incognito_md.xml
[modify] https://crrev.com/9828df63fe8ba13923c6ee9133fd7584b7dd3fc0/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java
[modify] https://crrev.com/9828df63fe8ba13923c6ee9133fd7584b7dd3fc0/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java

These screenshots show the layout if the two sets of bulletpoints don't fit next to each other on a wide screen:
wide-bulletpoints-1.png
126 KB View Download
wide-bulletpoints-2.png
153 KB View Download
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdbafc7eef4df3745e9fb1ab119e3fe2d5086ea6

commit fdbafc7eef4df3745e9fb1ab119e3fe2d5086ea6
Author: Martin Sramek <msramek@chromium.org>
Date: Tue Jul 11 11:59:19 2017

Fix the Android Incognito NTP wide layout with wide bulletpoints

On wide screens (width > 720dp), if the two sets of bulletpoints can't
be positioned horizontally next to each other, they must be positioned
vertically.

However, the specification suggests that in this case they should
not be centered under the subtitle, but left-aligned with the subtitle.
This can be most easily achieved by extending the container to match
the subtitle width.

As a side effect, this also addresses the first layout pass misalignment
bug, for which we had to add extra 10dp. This hack has now been removed.

See  crbug.com/693525  for screenshots.

Bug:  693525 
Bug: 740619
Change-Id: I176fdd26914d212da0acb54fbab7721562faca19
Reviewed-on: https://chromium-review.googlesource.com/566825
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485597}
[modify] https://crrev.com/fdbafc7eef4df3745e9fb1ab119e3fe2d5086ea6/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java

Martin, is this work complete now? M58 has shipped to Stable, so if we can't close this perhaps at least we can drop / update the target milestone. Maybe also the priority.
Labels: -Pri-1 -M-58 M-62 Pri-2
It is shipped on Desktop, and in development on Android (specifically, it works fine on Nexus devices, but has issues elsewhere, so it's not ready for launch).

It's still on my plate, but I haven't had much time for it lately, so I'm lowering to Pri=2.
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3cb619de0b9c1e7808ab9dac7104b6b4b99f024

commit b3cb619de0b9c1e7808ab9dac7104b6b4b99f024
Author: Martin Sramek <msramek@chromium.org>
Date: Thu Nov 30 17:21:40 2017

Clean up the old Desktop Incognito NTP

1. Remove the code of the old ("non-MD") Incognito NTP
2. Remove the qualifier "MD" from variable names (no longer necessary,
   as the "non-MD" version is removed)
3. Remove the qualifier "MD" from file names (as above; and thus
   overwrite the previous files).

Note: #3 was executed as:
> mv md_incognito_tab.css incognito_tab.css
> mv md_incognito_tabsjs incognito_tab.js
> mv md_incognito_tabshtml incognito_tab.html
And then inside md_incognito_tabs.html:
> s/md_incognito_tab/incognito_tab/
Although git understood this as delete+rename, the diffs in the code
compare the old files with the new ones, so it's not as well visible :(

Bug:  693525 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8e4096337dff097aaf400f15b2c2b7b8e1c9c475
Reviewed-on: https://chromium-review.googlesource.com/777319
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520584}
[modify] https://crrev.com/b3cb619de0b9c1e7808ab9dac7104b6b4b99f024/chrome/browser/about_flags.cc
[modify] https://crrev.com/b3cb619de0b9c1e7808ab9dac7104b6b4b99f024/chrome/browser/browser_resources.grd
[modify] https://crrev.com/b3cb619de0b9c1e7808ab9dac7104b6b4b99f024/chrome/browser/resources/ntp4/incognito_tab.css
[modify] https://crrev.com/b3cb619de0b9c1e7808ab9dac7104b6b4b99f024/chrome/browser/resources/ntp4/incognito_tab.html
[rename] https://crrev.com/b3cb619de0b9c1e7808ab9dac7104b6b4b99f024/chrome/browser/resources/ntp4/incognito_tab.js
[delete] https://crrev.com/1b37326136d3d9891ea11af23c0293fe78f5b988/chrome/browser/resources/ntp4/md_incognito_tab.css
[delete] https://crrev.com/1b37326136d3d9891ea11af23c0293fe78f5b988/chrome/browser/resources/ntp4/md_incognito_tab.html
[modify] https://crrev.com/b3cb619de0b9c1e7808ab9dac7104b6b4b99f024/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/b3cb619de0b9c1e7808ab9dac7104b6b4b99f024/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

I filed issue 850138 to track the remaining Android work, so I think we can close this out.
Blockedon: 850138
Status: Fixed (was: Started)
Technically there's iOS left too, but we can have a separate bug for that as well.

Comment 30 by sarj...@gmail.com, Jun 6 2018

So is there a bug for iOS work?  And should the OS:All label for this bug be updated?

Comment 31 by sarj...@gmail.com, Jun 6 2018

And can Issue 850138 be opened to the public?

Sign in to add a comment