New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 693521 link

Starred by 10 users
Status: Assigned
Owner:
dtapu...@chromium.org
Cc:
jakearchibald@chromium.org
rbyers@chromium.org
█ paritosh@chromium.org
mustaq@chromium.org
█ msrchandra@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 696686


Sign in to add a comment

Right-click on disabled element doesn’t show context menu

Project Member Reported by math...@qiwi.be, Feb 17 2017 
Chrome Version: 56.0.2924.87 (Official Build) (64-bit)
OS: macOS 10.12.3 (16D32) (I haven’t tested this on other operating systems)

What steps will reproduce the problem?
1) Go to https://jakearchibald.com/2017/events-and-disabled-form-fields/#serious
2) Right-click the disabled button

What is the expected result?

The context menu shows up

What happens instead?

The context menu doesn’t show up

Comment 1 by a...@chromium.org, Feb 27 2017

Components: Blink
Labels: -OS-Mac OS-All
Happens on Windows too.

Comment 2 by chrishtr@chromium.org, Feb 27 2017

Components: -Blink Blink>Input
Labels: Needs-Bisect M-56
Repros on 58.0.3013.3 / Linux. Firefox does show the context menu.

Comment 3 by math...@qiwi.be, Feb 27 2017 

I don’t think this needs bisecting — AFAIR, this never worked in Chromium.

Comment 4 by dtapu...@chromium.org, Feb 28 2017

Cc: mustaq@chromium.org
Labels: -Needs-Bisect Hotlist-Input-Dev
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
This is likely because we are suppressing the context menu event which is a mouse event. Will need to debug.

Comment 5 by dtapu...@chromium.org, Feb 28 2017

Blockedon: 696686
Cc: rbyers@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af6f27363128a72a89cb581f3073c0e068854308

commit af6f27363128a72a89cb581f3073c0e068854308
Author: dtapuska <dtapuska@chromium.org>
Date: Mon Apr 24 21:49:14 2017

Send mouse events for disabled form controls.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/rhNbsYDBJes/Jvmtv6IbBwAJ

The HTML spec clearly indicates that only click should be prevented. Add
a flag to change the behaviour and put it as an experimental flag for now.

Click events will not be dispatched if a disabled form control exists in
the event path.

BUG=696686, 693521

Review-Url: https://codereview.chromium.org/2832073003
Cr-Commit-Position: refs/heads/master@{#466783}

[add] https://crrev.com/af6f27363128a72a89cb581f3073c0e068854308/third_party/WebKit/LayoutTests/fast/forms/mouseevent_disabled_form_control.html
[modify] https://crrev.com/af6f27363128a72a89cb581f3073c0e068854308/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/af6f27363128a72a89cb581f3073c0e068854308/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] https://crrev.com/af6f27363128a72a89cb581f3073c0e068854308/third_party/WebKit/Source/core/events/EventPath.h
[modify] https://crrev.com/af6f27363128a72a89cb581f3073c0e068854308/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/af6f27363128a72a89cb581f3073c0e068854308/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/af6f27363128a72a89cb581f3073c0e068854308/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 8 by mustaq@chromium.org, Jan 29 2018

Cc: msrchandra@chromium.org paritosh@chromium.org
 Issue 417664  has been merged into this issue.
►

Sign in to add a comment