New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693510 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add suppression for upcoming Skia DEPS roll

Project Member Reported by robertphillips@chromium.org, Feb 17 2017

Issue description

The Skia CL https://skia-review.googlesource.com/c/8498/ (Replace SkSpecialImage::makeTightSubset with asImage) introduced some imperceptible diffs to the following layout tests:

  compositing/overlap-blending/reflection-opacity-huge.html [ Failure ]
  compositing/reflections/animation-inside-reflection.html [ Failure ]
  compositing/reflections/deeply-nested-reflections.html [ Failure ]
  compositing/reflections/load-video-in-reflection.html [ Failure ]
  compositing/reflections/nested-reflection-anchor-point.html [ Failure ]
  compositing/reflections/nested-reflection-animated.html [ Failure ]
  compositing/reflections/nested-reflection-mask-change.html [ Failure ]
  compositing/reflections/nested-reflection-opacity.html [ Failure ]
  media/video-layer-crash.html [ Failure ]
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9187e4de3abf2fca18590e91f619b7b9cc0f8f25

commit 9187e4de3abf2fca18590e91f619b7b9cc0f8f25
Author: robertphillips <robertphillips@google.com>
Date: Sat Feb 18 23:21:05 2017

Add suppressions for upcoming Skia DEPS roll

BUG= 693510 

Review-Url: https://codereview.chromium.org/2702703002
Cr-Commit-Position: refs/heads/master@{#451498}

[modify] https://crrev.com/9187e4de3abf2fca18590e91f619b7b9cc0f8f25/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da6bb130906d829798ade6529aecbf05cca19efa

commit da6bb130906d829798ade6529aecbf05cca19efa
Author: robertphillips <robertphillips@google.com>
Date: Sun Feb 19 22:29:34 2017

AutoRebaseline Layout tests suppressed for Skia roll

The Skia CL that caused the layout test changes (https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2))) has landed in Skia
and rolled into Chrome (https://codereview.chromium.org/2704913003) at r451504.

TBR=fmalita@chromium.org
BUG= 693510 

Review-Url: https://codereview.chromium.org/2706693003
Cr-Commit-Position: refs/heads/master@{#451528}

[modify] https://crrev.com/da6bb130906d829798ade6529aecbf05cca19efa/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4abde4e18f7453c6fe591ad27fca4112a67b7f

commit da4abde4e18f7453c6fe591ad27fca4112a67b7f
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Sun Feb 19 23:25:31 2017

Auto-rebaseline for r451528

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/610230

https://chromium.googlesource.com/chromium/src/+/da6bb130906d8

BUG= 693510 
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2701303002 .
Cr-Commit-Position: refs/heads/master@{#451529}

[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/linux/compositing/overlap-blending/reflection-opacity-huge-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/animation-inside-reflection-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/deeply-nested-reflections-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/load-video-in-reflection-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-mask-change-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-opacity-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/linux/media/video-layer-crash-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/animation-inside-reflection-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/deeply-nested-reflections-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-mask-change-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/mac/media/video-layer-crash-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/animation-inside-reflection-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/deeply-nested-reflections-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-mask-change-expected.png
[modify] https://crrev.com/da4abde4e18f7453c6fe591ad27fca4112a67b7f/third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.png
[delete] https://crrev.com/da6bb130906d829798ade6529aecbf05cca19efa/third_party/WebKit/LayoutTests/platform/win7/media/video-layer-crash-expected.png

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/813de3871ce80bbb54755202264fd00dba9d42f8

commit 813de3871ce80bbb54755202264fd00dba9d42f8
Author: robertphillips <robertphillips@google.com>
Date: Mon Feb 20 01:38:38 2017

Restore conflicting layout test suppression

This suppression conflicted with those in https://codereview.chromium.org/2702703002/ (Add suppressions for upcoming Skia DEPS roll).

This CL cannot land until the rebaselines requested in https://codereview.chromium.org/2706693003/ (AutoRebaseline Layout tests suppressed for Skia roll) have landed.

BUG= 693510 

Review-Url: https://codereview.chromium.org/2705903002
Cr-Commit-Position: refs/heads/master@{#451540}

[modify] https://crrev.com/813de3871ce80bbb54755202264fd00dba9d42f8/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c94b8d06ccb12a284dec1e337a3380ba4cda767f

commit c94b8d06ccb12a284dec1e337a3380ba4cda767f
Author: fs <fs@opera.com>
Date: Mon Feb 20 16:08:10 2017

Disable flaky compositing/reflections/nested-reflection-* tests

The following two tests appear to produce slightly different results
(different offsets?) somewhat randomly:

 compositing/reflections/nested-reflection-anchor-point.html
 compositing/reflections/nested-reflection-animated.html

TBR=cfroussios@chromium.org
NOTRY=true
BUG= 693510 

Review-Url: https://codereview.chromium.org/2702343002
Cr-Commit-Position: refs/heads/master@{#451635}

[modify] https://crrev.com/c94b8d06ccb12a284dec1e337a3380ba4cda767f/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
The flakiness should be fixed and test expectations should be removed before closing this bug. If the we never want to fix the bug, please move the test expectations into NeverFixTests.
I believe crbug.com/653722 is for the flakiness issue. This issue was just created as part of the process for landing suppressions for a DEPS roll and then rebaselining the images (which is complete).
Cc: wangxianzhu@chromium.org
Status: Fixed (was: Assigned)
As comment #8 says, the flakiness is tracked in crbug.com/653722, so this should be closed.
Thanks for the replies. We should update the bug numbers in TestExpectations.
I'll put up a CL.
It looks like I've been beaten to the punch. :)

Sign in to add a comment