New issue
Advanced search Search tips

Issue 693496 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Test WebSocketDeflateStream with small window sizes

Project Member Reported by ricea@chromium.org, Feb 17 2017

Issue description

This is a continuation of  issue 691074  "WebSockets uses zlib deflate with windowBits = 8 and no zlib/gzip wrapper". During investigation of that issue we identified some testing gaps. Items to address:

1. Modify fuzzer to vary the window sizes it tests with.
2. Add a round-trip test with a window size of 8.
3. Create a sample frame with offsets > 255 and verify that decompression fails safely with server_max_window_bits=8
4. Compress some sample data with client_max_window_bits=8 and verify no offsets > 255 are created.

The last two are stretch goals as they are probably too much work to implement.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2d77f89b0296318db4239d657a191bf4c7cad2

commit 1c2d77f89b0296318db4239d657a191bf4c7cad2
Author: ricea <ricea@chromium.org>
Date: Tue Feb 28 12:58:19 2017

Vary the parameters to WebSocketDeflateStream in fuzzer

Previously, the fuzzer for WebSocketDeflateStream always initialised it with
default parameters. Vary the initialisation parameters in order to increase
coverage.

BUG=693496
R=yhirano

Review-Url: https://codereview.chromium.org/2706433003
Cr-Commit-Position: refs/heads/master@{#453580}

[modify] https://crrev.com/1c2d77f89b0296318db4239d657a191bf4c7cad2/net/websockets/websocket_deflate_stream_fuzzer.cc

Comment 2 by ricea@chromium.org, Apr 12 2018

Status: Assigned (was: Started)

Sign in to add a comment