Regression:Error message is not seen when text is dropped in Copies section of print preview |
|||||
Issue descriptionChrome Version:58.0.3015.0 dev OS:Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome and open any page, click Ctrl+p(print preview) (2)Enter some random text in Pages, error message will be displayed. (3)Select and drag that error message in Copies section and Observe.(kindly refer video) Expected Result: Error message should appear when text is dragged and dropped in Copies section. Actual Result:Instead, No error message appears. This is a Regression issue broken in M-56 Manual Bisect info: =================== Good Build:56.0.2897.0 Bad Build :56.0.2898.0
,
Feb 17 2017
Using the per-revision bisect providing the bisect results, Good Build -- 56.0.2897.0 (revision : 426673) Bad Build -- 56.0.2898.0 (revision : 426930) You are probably looking for a change made after 426690 (known good), but no later than 426691 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/664d4716b91e01c779a77702e9f219c2744724e0..ee33e4e0e8e7da42e4f7cae338da35e851b300fa @rbpotter -- Could you please look into the issue, kindly re-assign if this is not related to your changes. Thank You.
,
Feb 23 2017
Friendly ping!! rbpotter@, Could you please take look into this. Thank you!!
,
Feb 24 2017
This is a pretty obscure edge case, and does not cause any printing errors since we reset the value to 1 as soon as focus shifts from the copies box to print or change some other setting. So definitely not P1.
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1d9ece59f24058d02965208c692c4204dcef799 commit c1d9ece59f24058d02965208c692c4204dcef799 Author: rbpotter <rbpotter@chromium.org> Date: Tue Feb 28 19:24:47 2017 Print Preview: Show error message if text is typed in Copies section Native number input type returns an empty string for the current value if it is invalid (non-numeric). Change to show an error message if this happens. Previously did not show an error message in this case as the old text input field would return the text in the field rather than an empty string. Also: - fix both copies and scaling handling of scientific notation. - remove regex parsing and use native input error checking BUG= 693493 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2713033003 Cr-Commit-Position: refs/heads/master@{#453661} [modify] https://crrev.com/c1d9ece59f24058d02965208c692c4204dcef799/chrome/browser/resources/print_preview/data/ticket_items/copies.js [modify] https://crrev.com/c1d9ece59f24058d02965208c692c4204dcef799/chrome/browser/resources/print_preview/data/ticket_items/scaling.js [modify] https://crrev.com/c1d9ece59f24058d02965208c692c4204dcef799/chrome/browser/resources/print_preview/settings/copies_settings.js [modify] https://crrev.com/c1d9ece59f24058d02965208c692c4204dcef799/chrome/browser/resources/print_preview/settings/scaling_settings.js
,
Mar 1 2017
,
Mar 7 2017
Verified this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.3 with chrome dev #58.0.3029.6 Observed that Error message is appearing when text is dragged and dropped in Copies section. Attaching the screen-cast for reference. Adding TE-Verified labels |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kavvaru@chromium.org
, Feb 17 2017Status: Untriaged (was: Unconfirmed)