User doesn't have Code-Review+1 access rights |
|||
Issue descriptionI've been asked to review a CL through Gerrit (https://chromium-review.googlesource.com/c/444271/), I'm signed in with my account. I've been told that I should give +1/+2 on the CL, but I don't see the buttons in the UI. See attached screenshot. I would expect that either 1. or 2. is true: 1. I can review the CL and thus see +1/+2, 2. I cannot review the CL (lack of privilege) and get a huge text saying "you do not have privilege to review this CL" (or another wording). Bonus points if scores are replaced by lgtm/not lgtm buttons.
,
Feb 21 2017
I've given you permission to -1 or +1 a CL.
,
Feb 22 2017
Sorry, I got confused. I didn't give sdefresne permission to -1 or +1 CLs. I think that only infra committers and recipe owners whose +1 is sufficient to get a CL through the CQ have +1 permission. I was hoping there would be some way to give people permission to express their content with a CL (like adding Code-Review+1) even if they are not infra committers or recipe owners.
,
Feb 22 2017
Yep, agreed, we need to work on this. Personally, I'm a fan of the CR+1/CR+2 distinction (the same as google3's LGTM/Approval distinction), but a lot of chromium developers have pushed back on having that in the initial switchover. In the mean time, the behavior sdefresne describes in (2) is the correct behavior here. Duping into a bug where I track that. |
|||
►
Sign in to add a comment |
|||
Comment 1 by andyb...@chromium.org
, Feb 21 2017Owner: aga...@chromium.org
Status: Assigned (was: Untriaged)
Summary: User doesn't have Code-Review+1 access rights (was: Gerrit UI is confusing)