New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693457 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.9% regression in blink_perf.bindings at 450332:450361

Project Member Reported by alexclarke@chromium.org, Feb 17 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=693457

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguO6cuAoM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 18 2017

Cc: andypaicu@google.com
Owner: andypaicu@google.com

=== Auto-CCing suspected CL author andypaicu@google.com ===

Hi andypaicu@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : andypaicu
  Commit : 9801daec162285a1f2c6695682ace5d508ea9b7f
  Date   : Tue Feb 14 15:27:48 2017
  Subject: Support data URLs in worker constructors to be inline with spec.

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : document-implementation/document-implementation
  Change       : 9.89% | 207.606798087 -> 187.073027125

Revision             Result                  N
chromium@450331      207.607 +- 14.3302      6      good
chromium@450346      199.067 +- 11.7808      6      good
chromium@450354      197.973 +- 12.7704      6      good
chromium@450356      194.21 +- 2.1998        6      good
chromium@450357      195.437 +- 9.21773      6      good
chromium@450358      182.087 +- 10.752       6      bad       <--
chromium@450361      187.073 +- 1.2652       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987421893234293456

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5896623265153024


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: ----
I don't think this is in any way related to my patch. I updated the worker constructor and did not affect in any way document.implementation. 

It's probably worth running another bisect and see if it points to anything else.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Feb 21 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to continue

Bisect was stopped because a commit couldn't be classified as either
good or bad.


Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : document-implementation/document-implementation


To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987041367630897392

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5908813615464448


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Untriaged)
This alert was found before M-60 branched. Closing as WontFix as this is believed to either be invalid or non-reproducible.

Sign in to add a comment