New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 693437 link

Starred by 1 user
Status: Fixed
Owner:
yiyix@chromium.org
Closed: Feb 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Cursor of Omnibox stays in LTR mode even after changing browser language to RTL mode

Reported by jshan...@etouch.net, Feb 17 2017 
Chrome Version: 58.0.3015.0 (Official Build) 2db168c3d25fe70212765f4b7404711031a8b827-refs/heads/master@{#451180}-32/64 bit
OS:  Windows(7,8,8.1,10)

Steps:
1. Launch Chrome and change the language to 'Arabic' from chrome://settings/languages
2. Relaunch, go to NTP and click on omnibox and observe

Actual: Cursor of Omnibox stays in LTR mode even after changing browser language to RTL mode

Expected: Cursor should be seen in RTL mode for Arabic language i.e at right side in omnibox

This is regression issue broken in 'M 58' and will soon update other info.

Manual Bisect Info: 
Good Build 58.0.3014.0
Bad Build 58.0.3015.0
 
Note:
This issue is not seen on Mac and Linux OS
Actual_video.mp4
420 KB View Download
Expected_video.mp4
187 KB View Download

Comment 1 by kkaluri@chromium.org, Feb 17 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: yiyix@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 58.0.3014.0,  Revision Range -450840
Bad build  : 58.0.3015.0,  Revision Range -451180

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/a255f7468a598ea8cf8a5ab0e21ab0047f52568a..a33c8f5acb10c229da14134b9987e3b16eaa74f4


The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/a33c8f5acb10c229da14134b9987e3b16eaa74f4


Review-Url: https://codereview.chromium.org/2660593002

yiyix@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 2 by yiyix@chromium.org, Feb 20 2017

Status: Started (was: Assigned)
I have verified and it is caused by my cl. I am working on it now.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/947341f55da060dd30bd492ab806049fb23bb109

commit 947341f55da060dd30bd492ab806049fb23bb109
Author: yiyix <yiyix@chromium.org>
Date: Thu Feb 23 17:30:24 2017

Cursor of Omnibox stays in LTR mode after setting to RTL mode

Fixed the bug caused by https://codereview.chromium.org/2660593002/.
The newly introduced |cursor_view_| did not consider RTL input mode.

TEST=TextfieldTest.TextCursorPositionInRTLTest and
TextfieldTest.TextCursorPositionInLTRTest

BUG= 693437 

Review-Url: https://codereview.chromium.org/2709633003
Cr-Commit-Position: refs/heads/master@{#452536}

[modify] https://crrev.com/947341f55da060dd30bd492ab806049fb23bb109/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/947341f55da060dd30bd492ab806049fb23bb109/ui/views/controls/textfield/textfield_test_api.h
[modify] https://crrev.com/947341f55da060dd30bd492ab806049fb23bb109/ui/views/controls/textfield/textfield_unittest.cc

Comment 4 by yiyix@chromium.org, Feb 25 2017

Status: Fixed (was: Started)

Comment 5 by jmukthavaram@chromium.org, Feb 28 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3025.5
Tested the issue on windows 7 using chrome version#58.0.3025.5 with the steps mentioned in comment #0.Observed that Cursor seen right hand side in omnibox for Arabic language which is working as expected.Hence adding TE-Verified labels.
Please find the attached screen cast for the same.
Thanks!!
693437.mp4
657 KB View Download
►

Sign in to add a comment