New issue
Advanced search Search tips

Issue 693430 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Memory coordinator: Budget API

Project Member Reported by bashi@chromium.org, Feb 17 2017

Issue description

V8 and other components (like cc) want to know how much memory they can use. We should provide some APIs to provide such information. In the future, this kind of APIs will be moved to GRC[1], but as a first step we can start with something like chrisha@'s WIP CL[2]. We will write a design doc.

[1] https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3 (internal doc)
[2] https://codereview.chromium.org/2479673002/

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e0e67fdb9bd900fb4f7d6e7166f60a53800e2ed

commit 4e0e67fdb9bd900fb4f7d6e7166f60a53800e2ed
Author: bashi <bashi@chromium.org>
Date: Mon Feb 20 06:16:26 2017

Refactor MemoryCoordinatorProxy

Before this CL we used two callbacks to inject content -> base
dependency. Now we plan to add another method which will provide
remaining memory budget (WIP CL can be found [1]). Rather than adding
another callback we should simply use an interface to inject dependency.

[1] https://codereview.chromium.org/2479673002/

BUG= 693430 

Review-Url: https://codereview.chromium.org/2703743002
Cr-Commit-Position: refs/heads/master@{#451573}

[modify] https://crrev.com/4e0e67fdb9bd900fb4f7d6e7166f60a53800e2ed/base/memory/memory_coordinator_proxy.cc
[modify] https://crrev.com/4e0e67fdb9bd900fb4f7d6e7166f60a53800e2ed/base/memory/memory_coordinator_proxy.h
[modify] https://crrev.com/4e0e67fdb9bd900fb4f7d6e7166f60a53800e2ed/content/browser/browser_main_loop.cc
[modify] https://crrev.com/4e0e67fdb9bd900fb4f7d6e7166f60a53800e2ed/content/browser/memory/memory_coordinator_impl.cc
[modify] https://crrev.com/4e0e67fdb9bd900fb4f7d6e7166f60a53800e2ed/content/browser/memory/memory_coordinator_impl.h
[modify] https://crrev.com/4e0e67fdb9bd900fb4f7d6e7166f60a53800e2ed/content/browser/memory/memory_coordinator_impl_unittest.cc
[modify] https://crrev.com/4e0e67fdb9bd900fb4f7d6e7166f60a53800e2ed/content/public/test/memory_coordinator_test_utils.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d43ce5d5dc0b568a1c0ec616012ebc38e9d9e8b3

commit d43ce5d5dc0b568a1c0ec616012ebc38e9d9e8b3
Author: bashi <bashi@chromium.org>
Date: Fri Mar 24 00:51:17 2017

Initialize ChildMemoryCoordinator before blink

Some features of memory coordinator will be exposed to v8. We should
initialize ChildMemoryCoordinator before blink to make sure that v8
can access memory coordinator features from the beginning.

BUG= 693430 

Review-Url: https://codereview.chromium.org/2775583002
Cr-Commit-Position: refs/heads/master@{#459308}

[modify] https://crrev.com/d43ce5d5dc0b568a1c0ec616012ebc38e9d9e8b3/content/renderer/render_thread_impl.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/296ebdae36af19a38f2356b28c70f27fa71a89ec

commit 296ebdae36af19a38f2356b28c70f27fa71a89ec
Author: bashi <bashi@chromium.org>
Date: Tue Mar 28 03:27:09 2017

Revert of Initialize ChildMemoryCoordinator before blink (patchset #3 id:40001 of https://codereview.chromium.org/2775583002/ )

Reason for revert:
This caused renderer crashes.

BUG=705021

Original issue's description:
> Initialize ChildMemoryCoordinator before blink
>
> Some features of memory coordinator will be exposed to v8. We should
> initialize ChildMemoryCoordinator before blink to make sure that v8
> can access memory coordinator features from the beginning.
>
> BUG= 693430 
>
> Review-Url: https://codereview.chromium.org/2775583002
> Cr-Commit-Position: refs/heads/master@{#459308}
> Committed: https://chromium.googlesource.com/chromium/src/+/d43ce5d5dc0b568a1c0ec616012ebc38e9d9e8b3

TBR=haraken@chromium.org,avi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 693430 

Review-Url: https://codereview.chromium.org/2777393002
Cr-Commit-Position: refs/heads/master@{#459996}

[modify] https://crrev.com/296ebdae36af19a38f2356b28c70f27fa71a89ec/content/renderer/render_thread_impl.cc

Comment 4 by bashi@chromium.org, Feb 20 2018

Status: Archived (was: Assigned)

Sign in to add a comment