Regression: Blank error window is seen in share overlay in Files.app |
|||||
Issue descriptionChrome Version: 58.0.3011.0/9287.0.0 dev-channel Samus, Link, Butterfly OS: Chrome What steps will reproduce the problem? (1) Sign in to user>> go to Files.app>> go to my drive tab>> create one folder>> try to share>> give wrong email I'd in people edit box>> click on send observe Expected: Error message should be seen (Refer screenshot) Actual: Instead blank window is seen (Refer screenshot) This is a Regression issue as such behavior is not seen in 58.0.03007.0/9281.0.0 dev-channel Samus Issue is not applicable to Linux and Windows
,
Feb 21 2017
,
Feb 21 2017
Reproduced on 55.0.2883.105. Chromebook Pixel 2. When the blank overlay appears, I could often see the animation like the expected error message and the button is displayed but quickly scrolling out downwards. After getting the blank window, I could see the expected error message and button by clicking outside the error window but int the app. (1 to 3 times, varied each time).
,
Feb 21 2017
Changing the Type to Bug (not regression), based on #3. I found a JS code in inside the Files app. is waiting for a condition inifinitely when this is happening. I will take a further look.
,
Feb 21 2017
The expected behavior of current code is that the webview (which hosts the input form and the error message) should also be centered. I think the screenshot "Expected-Share.png" in #0 is not 100% expected. (left margin is too small) The attached screencapture is after applying the planned fix: https://codereview.chromium.org/2702423002/
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/479ccd4b4d85396ed50eed8ce07b1b7dd9199109 commit 479ccd4b4d85396ed50eed8ce07b1b7dd9199109 Author: yamaguchi <yamaguchi@chromium.org> Date: Wed Feb 22 06:44:07 2017 Detect webview size change by motion instead of expected size. This is a workaround to avoid that the webview size never gets to the expected size, thus it does not issue resizeComplete message at all. One caveat of this method is that when there is an animation jank longer than the polling interval (200ms), it'll be detected as the false end of the animation. In this case, the resizeComplete message won't be issued after actual end of the animation. BUG= 693416 TEST=Open share dialog in Files.app, enter "." as email address, click "Send" button. Verify the error message is visible. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2702423002 Cr-Commit-Position: refs/heads/master@{#451902} [modify] https://crrev.com/479ccd4b4d85396ed50eed8ce07b1b7dd9199109/ui/file_manager/file_manager/foreground/js/ui/share_dialog.js
,
Feb 22 2017
,
Mar 1 2017
58.03021.0/9325.0.0 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mtomasz@chromium.org
, Feb 21 2017