Regression: Unwanted Advance setting option is seen in chrome://md-settings for Guest mode.
Reported by
lpa...@etouch.net,
Feb 17 2017
|
|||||||||
Issue descriptionChrome Version: 58.0.3015.0 (Official Build) 2db168c3d25fe70212765f4b7404711031a8b827-refs/heads/master@{#451180}(32/64 Bit) OS: Windows(7,8,8.1,10), Mac(10.11.6, 10.12.1, 10.12) Steps to reproduce: 1. Launch Chrome,click on Avatar icon and enter guest mode , 2. go to chrome://md-settings, Click on the Main menu icon in top left corner and observe Actual Result: Unwanted Advance setting option is seen and is not accessible. Expected Result: Advance settings should not be seen for Guest user. This is regression issue broken in 'M 58' and will soon update other info. Manual Bisect Info: Good Build 58.0.3014.0 Bad Build 58.0.3015.0
,
Feb 17 2017
,
Feb 17 2017
,
Feb 17 2017
Issue also reproducible on Linux(14.04 LTS OS)
,
Feb 17 2017
Using the per-revision bisect providing the bisect results, Good build: 58.0.3014.0 (Revision: 450840). Bad build: 58.0.3015.0 (Revision: 451180). You are probably looking for a change made after 451006 (known good), but no later than 451007 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/953322582e01e05f831456fecea0d48af331f16f..f26ccb9043c276fb76b875f90361ef5b58acc510 From the CL above, assigning the issue to the concern owner @hcarmona:Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2651293003 Note:Able to reproduce the issue in Ubuntu 14.04, Win 10.0 and Mac 10.12.3 and able to reproduce in latest canary #58.0.3015.0
,
Feb 17 2017
This was me, I recently changed the side nav.
,
Feb 17 2017
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d7e814d475cbb9804ba706eac482fea6ff1980b commit 0d7e814d475cbb9804ba706eac482fea6ff1980b Author: hcarmona <hcarmona@chromium.org> Date: Thu Feb 23 02:03:27 2017 MD-Settings: Don't show advanced settings in guest mode R=dschuyler@chromium.org BUG= 693398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2700113004 Cr-Commit-Position: refs/heads/master@{#452345} [modify] https://crrev.com/0d7e814d475cbb9804ba706eac482fea6ff1980b/chrome/browser/resources/settings/settings_menu/settings_menu.html
,
Feb 28 2017
Verified on Mac os 10.12.2 , ubuntu 14.04 and windows 7 using chrome dev M58 #58.0.3025.5 and issue is not reproduced. Advance settings is not seen for Guest user and issue is fixed. Attached screencast for reference. Adding Te-Verified labels . Thanks!
,
Feb 28 2017
Forgot to mark "Fixed" |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by michae...@chromium.org
, Feb 17 2017Status: Assigned (was: Unconfirmed)