New issue
Advanced search Search tips

Issue 693373 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Feb 2017
Cc:
tommycli@chromium.org
dpa...@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

a11y: Missing labels found when testing MD Settings with VoiceOver

Project Member Reported by lpalmaro@chromium.org, Feb 17 2017 
 
Chrome Canary: 58.0.3013.0
Mac with VoiceOver

- In Advanced Settings, under content settings, the button is missing a label.

- In the languages portion, the 3 dot more options menu doesn't have a label.

- in the content settings area, there is a button with a question mark (for help). This is missing a label. 

- When I click the import bookmarks button, a dialog opens. The X close button doesn't have a label here. 

- When you click the manage passwords button and you get to those settings, the search icon in the top right doesn't have a label. 

Let me know if you'd like each of these to be filed separately.

Comment 1 by dbeam@chromium.org, Feb 23 2017

Blocking: 671375
Cc: dbeam@chromium.org dpa...@chromium.org
Labels: -Pri-2 Pri-1
Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)
the content settings learn more (?) is now labelled
manage passwords learn more (?) is now labelled, but the magnifying glass next to it is not, you're right

because Tommy has done a few of these previously (the (?)s), maybe he could look into these?
Screen Shot 2017-02-23 at 2.52.23 PM.png
75.1 KB View Download
Screen Shot 2017-02-23 at 2.53.43 PM.png
108 KB View Download

Comment 2 by dbeam@chromium.org, Feb 24 2017 

note: I'm handling the (X) close button on dialogs here:
https://codereview.chromium.org/2717613002/
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/067993e006fab2c08cd42cda616e65e682b17305

commit 067993e006fab2c08cd42cda616e65e682b17305
Author: dbeam <dbeam@chromium.org>
Date: Fri Feb 24 03:58:32 2017

MD Settings: add a bunch of dialog (X) aria-labels

R=dpapad@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2717613002
Cr-Commit-Position: refs/heads/master@{#452744}

[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/android_apps_page/android_apps_page.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/device_page/display_overscan_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/internet_page/network_proxy.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/internet_page/network_siminfo.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/reset_page/reset_profile_banner.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/067993e006fab2c08cd42cda616e65e682b17305/chrome/browser/resources/settings/site_settings/site_details.html

Comment 4 by dbeam@chromium.org, Feb 25 2017 

i'll also fix the Content Settings subpage arrow
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/311516d81989d2307f5211860653c5fc5d5636f4

commit 311516d81989d2307f5211860653c5fc5d5636f4
Author: dbeam <dbeam@chromium.org>
Date: Sat Feb 25 04:28:27 2017

MD Settings: fix aria-label of Content/Site Setting subpage arrow

TBR=dschuyler@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2718803002
Cr-Commit-Position: refs/heads/master@{#453066}

[modify] https://crrev.com/311516d81989d2307f5211860653c5fc5d5636f4/chrome/browser/resources/settings/privacy_page/privacy_page.html

Comment 6 by dbeam@chromium.org, Feb 27 2017

Cc: -dbeam@chromium.org tommycli@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Assigned)
eh, actually, i'll just fix all these
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6942d9ee1972d4ab6676d93625774940230a4

commit 76a6942d9ee1972d4ab6676d93625774940230a4
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 18:15:48 2017

MD Settings: add "More actions..." text to all vertical 3-dot menus

R=hcarmona@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6942d9ee1972d4ab6676d93625774940230a4

commit 76a6942d9ee1972d4ab6676d93625774940230a4
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 18:15:48 2017

MD Settings: add "More actions..." text to all vertical 3-dot menus

R=hcarmona@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6942d9ee1972d4ab6676d93625774940230a4

commit 76a6942d9ee1972d4ab6676d93625774940230a4
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 18:15:48 2017

MD Settings: add "More actions..." text to all vertical 3-dot menus

R=hcarmona@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6942d9ee1972d4ab6676d93625774940230a4

commit 76a6942d9ee1972d4ab6676d93625774940230a4
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 18:15:48 2017

MD Settings: add "More actions..." text to all vertical 3-dot menus

R=hcarmona@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6942d9ee1972d4ab6676d93625774940230a4

commit 76a6942d9ee1972d4ab6676d93625774940230a4
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 18:15:48 2017

MD Settings: add "More actions..." text to all vertical 3-dot menus

R=hcarmona@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6942d9ee1972d4ab6676d93625774940230a4

commit 76a6942d9ee1972d4ab6676d93625774940230a4
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 18:15:48 2017

MD Settings: add "More actions..." text to all vertical 3-dot menus

R=hcarmona@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6942d9ee1972d4ab6676d93625774940230a4

commit 76a6942d9ee1972d4ab6676d93625774940230a4
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 18:15:48 2017

MD Settings: add "More actions..." text to all vertical 3-dot menus

R=hcarmona@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6942d9ee1972d4ab6676d93625774940230a4

commit 76a6942d9ee1972d4ab6676d93625774940230a4
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 18:15:48 2017

MD Settings: add "More actions..." text to all vertical 3-dot menus

R=hcarmona@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6942d9ee1972d4ab6676d93625774940230a4

commit 76a6942d9ee1972d4ab6676d93625774940230a4
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 18:15:48 2017

MD Settings: add "More actions..." text to all vertical 3-dot menus

R=hcarmona@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/76a6942d9ee1972d4ab6676d93625774940230a4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c8849f73233c57e96ed90f730cb096d42ebae03

commit 6c8849f73233c57e96ed90f730cb096d42ebae03
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 27 22:14:00 2017

MD Settings: remove button-ness of magnifying glass in subpage search

Clicking/tapping it did nothing, it just added ripples and weight to the
page and wasn't labelled.

R=tommycli@chromium.org
BUG= 693373 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2717983002
Cr-Commit-Position: refs/heads/master@{#453357}

[modify] https://crrev.com/6c8849f73233c57e96ed90f730cb096d42ebae03/chrome/browser/resources/settings/settings_page/settings_subpage_search.html

Comment 17 by dbeam@chromium.org, Feb 27 2017

Status: Fixed (was: Started)
►

Sign in to add a comment