New issue
Advanced search Search tips

Issue 693370 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

a11y: Toggle buttons missing associations

Project Member Reported by lpalmaro@chromium.org, Feb 17 2017

Issue description

Chrome Canary: 58.0.3013.0
Mac with VoiceOver

The toggle buttons in MD Settings aren't associated with anything. When you use VoiceOver to navigate to them, they just speak "selected toggle button" (for example), but VoiceOver should say what the toggle button is for, i.e. what you are toggling. 
 
Owner: hcarmona@chromium.org
Status: Started (was: Untriaged)
Labelling all the toggles!
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/505735cda080442c7d251abc0dcf4601d7b041a7

commit 505735cda080442c7d251abc0dcf4601d7b041a7
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Feb 23 02:44:13 2017

MD-Settings: Adds an a11y label to most toggle buttons.

The only missing toggle button is for the network summary item. That
toggle is non-trivial to label, so it'll be labelled in its own CL.

BUG= 693370 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2705543003
Cr-Commit-Position: refs/heads/master@{#452357}

[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/internet_page/network_ip_config.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/internet_page/network_proxy.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/internet_page/network_siminfo.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/people_page/manage_profile.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/505735cda080442c7d251abc0dcf4601d7b041a7/chrome/browser/resources/settings/site_settings/protocol_handlers.html

Status: Fixed (was: Started)
All toggles should be labelled now.

Sign in to add a comment