New issue
Advanced search Search tips

Issue 693359 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Failed compile: instrumentation phase observed on Win 64 PGO for Official builder.

Project Member Reported by ranjitkan@chromium.org, Feb 17 2017

Issue description

Link to Builder:
================
https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-pgo/builds/756

Link to Log File:
=================
https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-pgo/builds/756/steps/Compile%3A%20Instrumentation%20phase./logs/stdio

Error from the Log:
===================
FAILED: obj/skia/skia/SkCanvas.obj 
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/skia/skia/SkCanvas.obj.rsp /c ../../third_party/skia/src/core/SkCanvas.cpp /Foobj/skia/skia/SkCanvas.obj /Fd"obj/skia/skia_cc.pdb"
c:\b\build\slave\win64-pgo\build\src\third_party\skia\src\core\skclipstack.h(11): fatal error C1083: Cannot open include file: '../private/SkMessageBus.h': No such file or directory
[5015/27691] CXX obj/skia/skia/SkBlitter_RGB16.obj
[5016/27691] CXX obj/skia/skia/SkBlitter_PM4f.obj
[5017/27691] CXX obj/skia/skia/SkBlitter_Sprite.obj
[5018/27691] CXX obj/skia/skia/SkClipStack.obj
FAILED: obj/skia/skia/SkClipStack.obj 
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/skia/skia/SkClipStack.obj.rsp /c ../../third_party/skia/src/core/SkClipStack.cpp /Foobj/skia/skia/SkClipStack.obj /Fd"obj/skia/skia_cc.pdb"
c:\b\build\slave\win64-pgo\build\src\third_party\skia\src\core\skclipstack.h(11): fatal error C1083: Cannot open include file: '../private/SkMessageBus.h': No such file or directory
[5019/27691] CXX obj/device/geolocation/public/interfaces/interfaces_blink_cpp_sources/geolocation.mojom-blink.obj
[5020/27691] CXX obj/skia/skia/SkBlitter.obj
[5021/27691] CXX obj/skia/skia/skia_trace_memory_dump_impl.obj
[5022/27691] CXX obj/skia/skia/SkColorLookUpTable.obj
[5023/27691] CXX obj/skia/skia/SkConvolver.obj
[5024/27691] CXX obj/skia/skia/SkDebug.obj
[5025/27691] CXX obj/skia/skia/SkDeque.obj
[5026/27691] CXX obj/skia/skia/SkColor.obj
[5027/27691] CXX obj/skia/skia/SkCubicClipper.obj
[5028/27691] CXX obj/skia/skia/SkColorSpace.obj
[5029/27691] CXX obj/skia/skia/SkColorSpace_A2B.obj
[5030/27691] CXX obj/skia/skia/SkColorSpace_XYZ.obj
[5031/27691] CXX obj/skia/skia/SkCpu.obj
[5032/27691] CXX obj/media/mojo/interfaces/image_capture_blink_cpp_sources/image_capture.mojom-blink.obj
[5033/27691] CXX obj/skia/skia/SkColorSpace_ICC.obj
[5034/27691] CXX obj/skia/skia/SkBlurImageFilter.obj
[5035/27691] CXX obj/skia/skia/SkColorFilterShader.obj
[5036/27691] CXX obj/skia/skia/SkDataTable.obj
[5037/27691] CXX obj/skia/skia/SkColorFilter.obj
[5038/27691] CXX obj/skia/skia/SkConfig8888.obj
[5039/27691] CXX obj/skia/skia/SkColorTable.obj
[5040/27691] CXX obj/skia/skia/SkColorShader.obj
[5041/27691] CXX obj/skia/skia/SkComposeShader.obj
[5042/27691] CXX obj/skia/skia/SkData.obj
[5043/27691] CXX obj/skia/skia/SkColorMatrixFilterRowMajor255.obj
[5044/27691] CXX obj/skia/skia/SkColorSpaceXform_A2B.obj
[5045/27691] CXX obj/skia/skia/SkDevice.obj
[5046/27691] CXX obj/skia/skia/SkColorSpaceXform.obj
[5047/27691] ACTION //third_party/catapult/tracing:generate_about_tracing(//build/toolchain/win:x64)
ninja: build stopped: subcommand failed.
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Using code search, Could this be something related to below change:

https://skia.git.corp.google.com/skia.git/+/c42a1cdd1de7a3cf57a9a5fd7363f5fb660e97d0

@reed, request you to please take a look into. Please help us to find an owner if not with respect to your change.
 

Comment 1 by mmoss@chromium.org, Feb 17 2017

Owner: sebmarchand@chromium.org
This build is skia.git@dd45f8195783efc7b8044b006eae5ea5ac127cc2, which is several days before c42a1cdd1de7a3cf57a9a5fd7363f5fb660e97d0 landed, so I doubt there's any relation. I'm thinking it might have just been some flake in the optimization step.
It's failing because an include file from Skia is missing ("SkMessageBus.h") and there's been a sync issue, so I don't think that this has anything to do with PGO, it's just that the gclient step failed.

Comment 3 by mmoss@chromium.org, Feb 17 2017

Status: WontFix (was: Assigned)
Oh, yeah, I didn't notice that this build was hit by that sync issue, in which case we should probably just write it off. If we really need a new m56, we should trigger another build.

Sign in to add a comment