Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 1 user
Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment
"ShelfAppBrowserTest.TabDragAndDrop" is flaky
Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 17 2017 Back to list
"ShelfAppBrowserTest.TabDragAndDrop" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJTaGVsZkFwcEJyb3dzZXJUZXN0LlRhYkRyYWdBbmREcm9wDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: tdander...@chromium.org
Labels: -Sheriff-Chromium
Owner: msw@chromium.org
Status: Assigned
Disabling this test here: https://codereview.chromium.org/2696133009/

Suspected cause is https://codereview.chromium.org/2696073002, re-assigning this to msw@ for investigation and to re-enable the test.
Labels: OS-Chrome
Project Member Comment 3 by bugdroid1@chromium.org, Feb 17 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dacabe34951dab7e52d9257532045a4a8d98151d

commit dacabe34951dab7e52d9257532045a4a8d98151d
Author: tdanderson <tdanderson@chromium.org>
Date: Fri Feb 17 17:20:32 2017

Disable ShelfAppBrowserTest.TabDragAndDrop

Recent flake caused by suspected patch set
https://codereview.chromium.org/2696073002,
test disabled. See  crbug.com/693341  for further
details.

BUG= 693341 
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2696133009
Cr-Commit-Position: refs/heads/master@{#451326}

[modify] https://crrev.com/dacabe34951dab7e52d9257532045a4a8d98151d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

Project Member Comment 4 by bugdroid1@chromium.org, Mar 21 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e350b397d2bbe19303903e925de460865541063f

commit e350b397d2bbe19303903e925de460865541063f
Author: msw <msw@chromium.org>
Date: Tue Mar 21 23:43:01 2017

Init shelf browser item status and re-enable test.

Call UpdateBrowserItemState on BrowserShortcutLauncherItemController creation.
(this initializes the status of the shelf's browser item on creation)
Enable the previously flaky test (relied on DidFinishNavigation notice)

BUG= 693341 
TEST=Automated test passes reliably
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2766913002
Cr-Commit-Position: refs/heads/master@{#458604}

[modify] https://crrev.com/e350b397d2bbe19303903e925de460865541063f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/e350b397d2bbe19303903e925de460865541063f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

Comment 5 by msw@chromium.org, Mar 21 2017
Status: Fixed
Labels: VerifyIn-60
Labels: VerifyIn-61
Sign in to add a comment