Issue metadata
Sign in to add a comment
|
Security: Heap-use-after-free in v8_inspector::protocol::Runtime::Frontend::consoleAPICalled
Reported by
chromium...@gmail.com,
Feb 17 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 58.0.3014.0 canary Operating System: Win7 1. Load the extension file. 2. Observe that example.com is opened with print dialog. 3. Open the Devtools with F12 and cancel the print dialog. 4. Crash. Crash/cc7a273580000000
,
Feb 18 2017
machenbach: Can you please help triage (as v8 sheriff)? It's possible the v8 embedder is responsible, but it does seem to be crashing fairly deeply in the v8 code. There are several mitigating factors here but it may be possible to tickle this under other circumstances. Setting priority to low for now. chromium.khalil@gmail.com can you confirm whether this happens on Chrome Stable/Beta or just on Canary?
,
Feb 18 2017
Able to repro this on Stable/Beta/Canary. This bug is similar to issue 657568 .
,
Feb 18 2017
Adding to triage for cluterfuzz sheriffs.
,
Feb 19 2017
dgozman: Could you please help triage? (Your username seemed to come up in a bunch of the git blames associated with the files in the stack trace). Thanks!
,
Feb 19 2017
,
Feb 20 2017
Yang, is this something on the V8 side?
,
Feb 20 2017
,
Feb 21 2017
Looks like we are trying to access stale V8InspectorSessionImpl (closing the debugger infobar should terminate it). Not sure how the print preview is related. Aleksey, mind taking a look?
,
Mar 23 2017
I've found a way to reduce too many user gestures for this crash. 1. Open index.html 2. Click "Start" button 3. Open the Devtools (on navigate.html) shouldn't be higher than low severity?
,
Mar 23 2017
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/2629f811ea2f784e810ea9a38c1d290097cfa8e3 commit 2629f811ea2f784e810ea9a38c1d290097cfa8e3 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 24 01:33:12 2017 [inspector] Increased chances of successful InjectedScriptSource compilation - added InspectorTest.setupInjectedScriptEnvironment method which mutates current context, - clear prototype of InjectedScript function and domAttributesWithObservableSideEffectOnGet. Second point increases chances that injected-script-source would be successfully compiled. BUG= chromium:693338 R=dgozman@chromium.org,luoe@chromium.org Review-Url: https://codereview.chromium.org/2770823003 Cr-Commit-Position: refs/heads/master@{#44081} [modify] https://crrev.com/2629f811ea2f784e810ea9a38c1d290097cfa8e3/src/inspector/injected-script-source.js [modify] https://crrev.com/2629f811ea2f784e810ea9a38c1d290097cfa8e3/src/inspector/injected_script_externs.js [modify] https://crrev.com/2629f811ea2f784e810ea9a38c1d290097cfa8e3/src/inspector/v8-injected-script-host.cc [modify] https://crrev.com/2629f811ea2f784e810ea9a38c1d290097cfa8e3/src/inspector/v8-injected-script-host.h [modify] https://crrev.com/2629f811ea2f784e810ea9a38c1d290097cfa8e3/test/inspector/console/destroy-context-during-log.js [modify] https://crrev.com/2629f811ea2f784e810ea9a38c1d290097cfa8e3/test/inspector/inspector.isolate [modify] https://crrev.com/2629f811ea2f784e810ea9a38c1d290097cfa8e3/test/inspector/protocol-test.js [add] https://crrev.com/2629f811ea2f784e810ea9a38c1d290097cfa8e3/test/inspector/runtime/runtime-evaluate-with-dirty-context-expected.txt [add] https://crrev.com/2629f811ea2f784e810ea9a38c1d290097cfa8e3/test/inspector/runtime/runtime-evaluate-with-dirty-context.js
,
Mar 24 2017
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6c2215325e34d6a311df5d7d65abb43e0a1edf05 commit 6c2215325e34d6a311df5d7d65abb43e0a1edf05 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 24 17:38:20 2017 [inspector] better isArrayLike for injected-script-source.js We should never check existing of the property by typeof obj.name check. BUG= chromium:693338 R=dgozman@chromium.org,luoe@chromium.org Review-Url: https://codereview.chromium.org/2767323002 Cr-Commit-Position: refs/heads/master@{#44113} [modify] https://crrev.com/6c2215325e34d6a311df5d7d65abb43e0a1edf05/src/inspector/injected-script-source.js [modify] https://crrev.com/6c2215325e34d6a311df5d7d65abb43e0a1edf05/src/inspector/injected_script_externs.js [modify] https://crrev.com/6c2215325e34d6a311df5d7d65abb43e0a1edf05/src/inspector/v8-injected-script-host.cc [modify] https://crrev.com/6c2215325e34d6a311df5d7d65abb43e0a1edf05/src/inspector/v8-injected-script-host.h [modify] https://crrev.com/6c2215325e34d6a311df5d7d65abb43e0a1edf05/test/inspector/protocol-test.js [modify] https://crrev.com/6c2215325e34d6a311df5d7d65abb43e0a1edf05/test/inspector/runtime/evaluate-with-generate-preview-expected.txt [modify] https://crrev.com/6c2215325e34d6a311df5d7d65abb43e0a1edf05/test/inspector/runtime/evaluate-with-generate-preview.js
,
Mar 24 2017
,
Mar 25 2017
,
Mar 28 2017
,
Mar 30 2017
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/aaafb4385dfedf20daf5682e4bbfe37269558923 commit aaafb4385dfedf20daf5682e4bbfe37269558923 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 31 15:30:23 2017 Merged: [inspector] Increased chances of successful InjectedScriptSource compilation Revision: 2629f811ea2f784e810ea9a38c1d290097cfa8e3 BUG= chromium:693338 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I93dac5a5d7dc794816e61eb8229f587ce6482bcc Reviewed-on: https://chromium-review.googlesource.com/465106 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/branch-heads/5.8@{#47} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} [modify] https://crrev.com/aaafb4385dfedf20daf5682e4bbfe37269558923/src/inspector/injected-script-source.js [modify] https://crrev.com/aaafb4385dfedf20daf5682e4bbfe37269558923/src/inspector/injected_script_externs.js [modify] https://crrev.com/aaafb4385dfedf20daf5682e4bbfe37269558923/src/inspector/v8-injected-script-host.cc [modify] https://crrev.com/aaafb4385dfedf20daf5682e4bbfe37269558923/src/inspector/v8-injected-script-host.h [modify] https://crrev.com/aaafb4385dfedf20daf5682e4bbfe37269558923/test/inspector/console/destroy-context-during-log.js
,
Mar 31 2017
I'm afraid the panel declined to reward for this bug, noting that even if the user performs the interaction required, the use after free would be very difficult to control and exploit.
,
Apr 3 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 6 2017
,
Jul 1 2017
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by chromium...@gmail.com
, Feb 17 2017