[Mac RTL] Dragging from location bar has favicon on left |
||||
Issue descriptionDrag a url from the location bar. In RTL mode the favicon should be on the right.
,
Feb 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c0ecf945d1514a474eb184587112cd7f50b7e9d commit 7c0ecf945d1514a474eb184587112cd7f50b7e9d Author: avi <avi@chromium.org> Date: Sat Feb 18 07:00:06 2017 [Mac RTL] Correctly position icons and fade text for RTL. Note that while icon positioning depends on the RTLness of the browser, fading of RTL text always happens. We always correctly fade RTL text (see -[TabView setTitle:]) and we should do so on drags. BUG= 693321 TEST=as in bug Review-Url: https://codereview.chromium.org/2703863004 Cr-Commit-Position: refs/heads/master@{#451436} [modify] https://crrev.com/7c0ecf945d1514a474eb184587112cd7f50b7e9d/chrome/browser/ui/cocoa/drag_util.h [modify] https://crrev.com/7c0ecf945d1514a474eb184587112cd7f50b7e9d/chrome/browser/ui/cocoa/drag_util.mm
,
Feb 18 2017
,
May 6 2017
As mentioned in Issue 719104 , I don't observe this behaviour for: - Chrome 60.0.3088.3 - OSX 10.12.4 - Chrome launched with OS language set to Arabic. In addition, the text appears to be blurrier than for LTR. avi@, could you re-evaluate if this was actually fixed?
,
May 6 2017
Re issue 719104 , yes, I can see this. The moving of the icon to the right for RTL is enabled when our experimental RTL support is turned on. Please verify with our experimental RTL support on.
,
May 6 2017
lgarron: > /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --enable-features=ExperimentalMacRTL -AppleLanguages "(he)" |
||||
►
Sign in to add a comment |
||||
Comment 1 by shrike@chromium.org
, Feb 18 2017