New issue
Advanced search Search tips

Issue 693315 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 353069



Sign in to add a comment

Selection API: Add a console warning about addRange() behavior change

Project Member Reported by tkent@chromium.org, Feb 17 2017

Issue description

Chrome Version: ToT
OS: All but iOS

We should warn about the behavior change of addRange().

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b7e091709d04f852f7572556c8dc6c1e8790fbb

commit 6b7e091709d04f852f7572556c8dc6c1e8790fbb
Author: tkent <tkent@chromium.org>
Date: Fri Feb 17 07:05:21 2017

Selection API: Show a deprecation message for a quirky addRange() behavior.

BUG= 693315 

Review-Url: https://codereview.chromium.org/2704443005
Cr-Commit-Position: refs/heads/master@{#451256}

[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/editing/selection/addRange-merging-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-00-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-04-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-12-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-16-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-20-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-24-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-28-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-32-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-36-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/fast/css/first-letter-rtc-crash-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/fullscreen/full-screen-contentEditable-crash-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/platform/linux/editing/selection/addRange-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/platform/mac/editing/selection/addRange-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/LayoutTests/platform/win/editing/selection/addRange-expected.txt
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/6b7e091709d04f852f7572556c8dc6c1e8790fbb/third_party/WebKit/Source/core/frame/Deprecation.cpp

Comment 2 by tkent@chromium.org, Feb 17 2017

Labels: ReleaseBlock-Stable Merge-Request-57
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 17 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment