New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693310 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

'moblab_RunSuite' object has no attribute 'run' - got pass cq?

Project Member Reported by shuqianz@chromium.org, Feb 17 2017

Issue description

https://uberchromegw.corp.google.com/i/chromeos/builders/guado_moblab-paladin/builds/5050
guado_moblab-paladin failed to run moblab_DummyServerSuite. Error:

	FAIL	moblab_RunSuite	moblab_RunSuite	timestamp=1487292320	localtime=Feb 16 16:45:20	Unhandled AttributeError: 'moblab_RunSuite' object has no attribute 'run'
  Traceback (most recent call last):
    File "/usr/local/autotest/client/common_lib/test.py", line 804, in _call_test_function
      return func(*args, **dargs)
    File "/usr/local/autotest/client/common_lib/test.py", line 461, in execute
      dargs)
    File "/usr/local/autotest/client/common_lib/test.py", line 347, in _call_run_once_with_retry
      postprocess_profiled_run, args, dargs)
    File "/usr/local/autotest/client/common_lib/test.py", line 376, in _call_run_once
      self.run_once(*args, **dargs)
    File "/usr/local/autotest/server/site_tests/moblab_RunSuite/moblab_RunSuite.py", line 35, in run_once
      self.run('rm -rf %s/*' % moblab_host.MOBLAB_IMAGE_STORAGE)
  AttributeError: 'moblab_RunSuite' object has no attribute 'run'
 

Comment 1 by sbasi@chromium.org, Feb 17 2017

Cc: akes...@chromium.org
Summary: 'moblab_RunSuite' object has no attribute 'run' - got pass cq? (was: 'moblab_RunSuite' object has no attribute 'run')
Bigger question is how did my CL get through the CQ??

https://chromium-review.googlesource.com/c/437750/

Comment 3 by dshi@chromium.org, Feb 22 2017

The test does not use server-side packaging:
http://cautotest.corp.google.com/afe/#tab_id=view_job&object_id=102622603

So the moblab_RunSuite test is the one deployed on drone. That's why CQ doesn't verify the test. I'm not exactly sure why we can't use ssp for this test. I can't think of any reason.

Comment 4 by sbasi@chromium.org, Feb 22 2017

Status: Assigned (was: Untriaged)
OOO, that answer makes sense. The breakage was in the test testing moblab not the autotest code on the MobLab.

I'm not sure why SSP is not enabled. I'll see if I can turn it on.
What's the follow up on this? How to we prevent it from happening again?
Ping. Any news on this?

Comment 7 by sbasi@chromium.org, Mar 17 2017

So the CL I wrote to fix this was flakely failing ~60% of the time. But following yesterday's discussion and fix on crbug.com/702225 I think enabling SSP was just making that race condition more likely to happen somehow as the flake was exactly the same.

So I can retest my CL now that that has landed and see if the flake went away.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df

commit aff8b8e83758eab6e0ccbff0b02b3b0bccde69df
Author: Simran Basi <sbasi@google.com>
Date: Tue Mar 21 19:13:15 2017

moblab_Runsuite enable SSP

BUG= chromium:693310 
TEST=trybot then run_suite call.

Change-Id: Ifbe1e9bfa2232bac7a0e175c17f86dad3a665c8b
Reviewed-on: https://chromium-review.googlesource.com/446055
Commit-Ready: Simran Basi <sbasi@chromium.org>
Tested-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df/server/site_tests/moblab_RunSuite/control.dummyServer
[modify] https://crrev.com/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df/server/site_tests/moblab_RunSuite/control.smoke

Comment 9 by sbasi@chromium.org, Mar 21 2017

Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df

commit aff8b8e83758eab6e0ccbff0b02b3b0bccde69df
Author: Simran Basi <sbasi@google.com>
Date: Tue Mar 21 19:13:15 2017

moblab_Runsuite enable SSP

BUG= chromium:693310 
TEST=trybot then run_suite call.

Change-Id: Ifbe1e9bfa2232bac7a0e175c17f86dad3a665c8b
Reviewed-on: https://chromium-review.googlesource.com/446055
Commit-Ready: Simran Basi <sbasi@chromium.org>
Tested-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df/server/site_tests/moblab_RunSuite/control.dummyServer
[modify] https://crrev.com/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df/server/site_tests/moblab_RunSuite/control.smoke

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df

commit aff8b8e83758eab6e0ccbff0b02b3b0bccde69df
Author: Simran Basi <sbasi@google.com>
Date: Tue Mar 21 19:13:15 2017

moblab_Runsuite enable SSP

BUG= chromium:693310 
TEST=trybot then run_suite call.

Change-Id: Ifbe1e9bfa2232bac7a0e175c17f86dad3a665c8b
Reviewed-on: https://chromium-review.googlesource.com/446055
Commit-Ready: Simran Basi <sbasi@chromium.org>
Tested-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df/server/site_tests/moblab_RunSuite/control.dummyServer
[modify] https://crrev.com/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df/server/site_tests/moblab_RunSuite/control.smoke

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df

commit aff8b8e83758eab6e0ccbff0b02b3b0bccde69df
Author: Simran Basi <sbasi@google.com>
Date: Tue Mar 21 19:13:15 2017

moblab_Runsuite enable SSP

BUG= chromium:693310 
TEST=trybot then run_suite call.

Change-Id: Ifbe1e9bfa2232bac7a0e175c17f86dad3a665c8b
Reviewed-on: https://chromium-review.googlesource.com/446055
Commit-Ready: Simran Basi <sbasi@chromium.org>
Tested-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df/server/site_tests/moblab_RunSuite/control.dummyServer
[modify] https://crrev.com/aff8b8e83758eab6e0ccbff0b02b3b0bccde69df/server/site_tests/moblab_RunSuite/control.smoke

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment