[Presentation API] Connection state is always 'connecting' if start a presentation with url "https://www.google.com" |
||||||||
Issue descriptionStart a presentation with url "https://www.google.com". Expect: connection state becomes 'connected' after presentation starts Actual: connection state is always 'connecting' even if presentation starts successfully Cause: We do not create PresentationReceiver object if presentation.receiver property is not accessed.
,
Mar 2 2017
Bin, we seem to think there's already another bug about there about this (that's been fixed). Can you verify whether this still an issue?
,
Mar 23 2017
Per discussion it's a bug. The connection should be connected independent of access via presentation.receiver.
,
Mar 23 2017
,
Mar 27 2017
Issue 705610 has been merged into this issue.
,
Mar 27 2017
Tried to create PresentationReceiver object in ChromeClientImpl. It fixed this bug but broke pages accessing navigator.presentation.receiver. ChromeClientImpl creates PresentationReceiver earlier than Presentation::receiver(), and may fire connectionavailable and message events before event handlers are registered...
,
Mar 29 2017
,
Apr 5 2017
+mlamouri@ we would like to fix this by creating navigator.presentation.receiver object by default (even if page does not access this attribute) if presentationReceiver flag is set. Any suggestion about how to do this? (Tried to create PresentationReceiver in LocalFrameClientImpl::dispatchDidClearWindowObjectInMainWorld(), it functionally works but breaks presentation receiver related layout tests and not sure how to fix them)
,
Apr 11 2017
zhabin@, so sorry for missing your comment here. Sounds like you found the solution to your problem though :) Note that we are trying to avoid setting up things in dispatchDidClearWindowObjectInMainWorld. If you look at modules/ModulesInitializer.cpp you will see that we are registering some callbacks to be run when a LocalFrame is initialised. It might not work fully for what you need but maybe something to look at if you are interested to clean this up :)
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cae9c010f6e47a9b306f10b8889f86a65b6e9cb0 commit cae9c010f6e47a9b306f10b8889f86a65b6e9cb0 Author: zhaobin <zhaobin@chromium.org> Date: Tue Apr 11 23:04:52 2017 [Presentation API] Change connection to 'connected' if start a presentation with "https://www.google.com" - always create navigator.presentation.receiver object for receiver page - create receiver PSImpl in PresentationDispatcher::DidFinishLoadDocument() - do not reset() if receiver page navigates from blank to https://www.google.com BUG= 693309 Review-Url: https://codereview.chromium.org/2801823003 Cr-Commit-Position: refs/heads/master@{#463820} [modify] https://crrev.com/cae9c010f6e47a9b306f10b8889f86a65b6e9cb0/content/renderer/presentation/presentation_dispatcher.cc [modify] https://crrev.com/cae9c010f6e47a9b306f10b8889f86a65b6e9cb0/content/renderer/presentation/presentation_dispatcher.h [modify] https://crrev.com/cae9c010f6e47a9b306f10b8889f86a65b6e9cb0/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp [modify] https://crrev.com/cae9c010f6e47a9b306f10b8889f86a65b6e9cb0/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h [modify] https://crrev.com/cae9c010f6e47a9b306f10b8889f86a65b6e9cb0/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
,
Apr 13 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by zhaobin@chromium.org
, Feb 17 2017