New issue
Advanced search Search tips

Issue 693305 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"PlatformAppBrowserTest.WindowDotPrintShouldBringUpPrintPreview" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 17 2017

Issue description

"PlatformAppBrowserTest.WindowDotPrintShouldBringUpPrintPreview" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5QbGF0Zm9ybUFwcEJyb3dzZXJUZXN0LldpbmRvd0RvdFByaW50U2hvdWxkQnJpbmdVcFByaW50UHJldmlldww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Failures happened in 16 Feb. No further failures for a day.
Possibly a wontfix. Keeping open to check back.
Labels: -Sheriff-Chromium
Owner: rbpotter@chromium.org
Status: Assigned (was: Untriaged)
Disabling the flaky test here: https://codereview.chromium.org/2689213017/

rbpotter@ has agreed to investigate the flakiness and re-enable.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bdc716d3d2537161e1b0b5f86e8f207bda3c727

commit 1bdc716d3d2537161e1b0b5f86e8f207bda3c727
Author: tdanderson <tdanderson@chromium.org>
Date: Mon Feb 20 22:20:43 2017

Disable PlatformAppBrowserTest.WindowDotPrintShouldBringUpPrintPreview

Disable this flaky test and re-assign for further
investigation.

BUG= 693305 
TBR=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2689213017
Cr-Commit-Position: refs/heads/master@{#451663}

[modify] https://crrev.com/1bdc716d3d2537161e1b0b5f86e8f207bda3c727/chrome/browser/apps/app_browsertest.cc

Having trouble reproducing this locally, but this looks a lot like http://crbug.com/620194. After calling window.print(), the test calls chrome.test.notifyPass() inside of the onload(). This may be leading to the same race referred to in that bug: creating a child window (print preview) and then shutting down the test inside the onload callback.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d57cf0fbb763f3e7b8cea4ffdea4213bd0c27c6

commit 0d57cf0fbb763f3e7b8cea4ffdea4213bd0c27c6
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Mar 21 18:52:08 2017

Try re-enabling WindowDotPrintShouldBringUpPrintPreview

Since bug 620194 is fixed, try re enabling the test to see if it is
still flaky. Tested 100x on workstation and could not reproduce the
CHECK it was hitting before.

BUG= 693305 

Review-Url: https://codereview.chromium.org/2767493002
Cr-Commit-Position: refs/heads/master@{#458492}

[modify] https://crrev.com/0d57cf0fbb763f3e7b8cea4ffdea4213bd0c27c6/chrome/browser/apps/app_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment