Extension-controlled indicators for MD settings |
|||||||
Issue descriptionA number of settings can be extension-controlled but do not show any indication of being controlled in chrome://md-settings. The controls should be disabled, but aren't. Attempting to change one of these controls causes the control to revert back to the extension-specified value almost immediately. * Appearance * Font size * "Customize fonts" subpage * Passwords and forms: issue 693226 * Privacy and security: lots of toggle buttons can be extension-controlled * Content settings: issue 693301 * Language and input * Language => "Offer to translate pages" * Accessibility * "Manage accessibility features" subpage (CrOS only) There are likely other settings which are only controllable on Windows or Mac that I haven't tested yet.
,
Feb 17 2017
On Windows: * Appearance => Show home button: "Use the New Tab Page" should be disabled if there is an extension-controlled homepage. Like other controls in this bug, tapping the "Use the New Tab Page" radio button causes a brief flicker but it remains unselected. A couple other Windows-only Settings overrides are WAI: * search engine provider (chrome_settings_overrides.search_provider) * on-startup page (chrome_settings_overrides.startup_pages) Both of these correctly disable the MD Settings controls and show the controlling extension. The "chrome_ui_overrides" manifest key overrides some bookmarks stuff but doesn't correspond to any Settings controls, and is behind a flag. AFAICT I've listed all of the issues outside of Chrome OS. Chrome OS may be missing extension-controlled indicators for things like devices and networks but I haven't investigated yet.
,
Feb 17 2017
,
Feb 18 2017
I'm looking into what I can help with using a ubuntu dev machine.
,
Feb 22 2017
It looks like I can do the font size/settings. I'll do that first.
,
Feb 23 2017
,
Mar 2 2017
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95dec86ee4d37aaef13df66737e46a93c669907a commit 95dec86ee4d37aaef13df66737e46a93c669907a Author: dschuyler <dschuyler@chromium.org> Date: Tue Mar 07 22:16:32 2017 [MD settings] controlled by extension icon on default font size This CL adds indicators for dropdown menus that are controled by an extension. An example of which is the default font size dropdown. BUG= 693302 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2728683004 Cr-Commit-Position: refs/heads/master@{#455246} [modify] https://crrev.com/95dec86ee4d37aaef13df66737e46a93c669907a/chrome/browser/resources/settings/controls/compiled_resources2.gyp [modify] https://crrev.com/95dec86ee4d37aaef13df66737e46a93c669907a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html [modify] https://crrev.com/95dec86ee4d37aaef13df66737e46a93c669907a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js
,
Mar 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/141e9ca007617a802a8a22e5e8a635d2d4e7dcff commit 141e9ca007617a802a8a22e5e8a635d2d4e7dcff Author: dschuyler <dschuyler@chromium.org> Date: Sat Mar 11 01:38:44 2017 [MD settings] show icon when slider controlled by something This CL adds a controlled-by indicator when a slider is controlled by policy or an extention. BUG= 693302 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2737083002 Cr-Commit-Position: refs/heads/master@{#456247} [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/browser/resources/settings/device_page/compiled_resources2.gyp [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/browser/resources/settings/device_page/display.js [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/browser/resources/settings/device_page/keyboard.html [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/browser/resources/settings/device_page/pointers.html [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/test/data/webui/cr_elements/cr_policy_pref_indicator_tests.js [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/test/data/webui/cr_elements/cr_slider_tests.js [add] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/test/data/webui/cr_elements/settings_private_test_constants.js [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/chrome/test/data/webui/settings/device_page_tests.js [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/ui/webui/resources/cr_elements/cr_slider/compiled_resources2.gyp [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/ui/webui/resources/cr_elements/cr_slider/cr_slider.html [modify] https://crrev.com/141e9ca007617a802a8a22e5e8a635d2d4e7dcff/ui/webui/resources/cr_elements/cr_slider/cr_slider.js
,
Mar 13 2017
I'm marking this broad bug fixed with the changes made so far. If there are further issues, let's switch to specific bugs.
,
Mar 17 2017
Assigning to myself to verify.
,
Mar 23 2017
Cool, tested again and confirmed everything on Windows is fixed.
,
Mar 27 2017
\o/ thanks Dave!
,
Mar 27 2017
(and Michael for helping bring this to our attention and verifying)
,
May 19 2017
Verified on ChromeOS 9460.42.0, 59.0.3071.57 using sample extension in c#1 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by michae...@chromium.org
, Feb 17 20172.2 KB
2.2 KB Download