Extension-controlled content settings are not properly indicated or disabled |
|||||||
Issue descriptionAn extension can set an entire content category to block/allow/ask (for <all_urls>). It can also set individual URL patterns to block/allow/ask. https://developer.chrome.com/extensions/contentSettings In chrome://md-settings/content, an extension-controlled category shows the correct secondary text (e.g., "Blocked") reflecting the extension's controlled value, but there is no indication that the setting is extension-controlled. Should there be? (Options shows the plugin indicator next to the category-wide setting.) In a content sub-page, e.g. chrome://md-settings/content-location, the toggle button for allowing or blocking a category should be disabled when controlled by an extension, but it remains enabled. Toggling the setting on and off (block/allow) seems to "work", but refreshing the page shows the toggle back at its extension-controlled setting. (Options disables the category-wide setting.) Specific URL pattern exceptions added by extensions do correctly show the extension-controlled indicator in a content settings category's sub-page.
,
Feb 17 2017
,
Feb 17 2017
,
Feb 22 2017
,
Feb 22 2017
In my opinion (feel free to propose why something else is better): In chrome://md-settings/content the policy/controlledBy indicator should not appear because the icon is used to explain why a control is not available (disabled). On the top level page, the row control is allowing the user to go into the sub-page, i.e. the control is not disabled. In the specific sub-pages for the content settings, there should be an icon for extension controlled policy. That is the parallel for the old options radio button. This is where the user is faced with a disabled control that should be explained.
,
Feb 22 2017
CC +bettes@ (for my opinion in #5 above).
,
Feb 23 2017
@dschuyler I agree that the extension-controlled indicator should be on the sub-pages next to the disabled toggle/control.
,
Feb 23 2017
,
Mar 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e192df5bae608faf8e02c2a26fc26e40552f2f8 commit 2e192df5bae608faf8e02c2a26fc26e40552f2f8 Author: dschuyler <dschuyler@chromium.org> Date: Sat Mar 04 03:55:00 2017 [MD settings] show icon when content settings are controlled by an extension This CL adds an policy/controlledBy icon to content settings when that setting is controlled by an extension. It also disables the toggle control for that content setting. BUG= 693301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2708013003 Cr-Commit-Position: refs/heads/master@{#454756} [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/chrome/browser/resources/settings/controls/settings_input.js [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/chrome/browser/resources/settings/internet_page/network_proxy.html [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/chrome/browser/resources/settings/on_startup_page/on_startup_page.html [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/chrome/browser/resources/settings/system_page/system_page.html [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/chrome/browser/ui/webui/policy_indicator_localized_strings_provider.cc [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/chrome/test/data/webui/settings/controlled_button_tests.js [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/ui/webui/resources/cr_elements/policy/cr_policy_pref_behavior.js [modify] https://crrev.com/2e192df5bae608faf8e02c2a26fc26e40552f2f8/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
,
Mar 8 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by michae...@chromium.org
, Feb 17 2017