Issue metadata
Sign in to add a comment
|
navigator.getVRDisplays() doesn't resolve when Vr Services are out of date or don't exist |
||||||||||||||||||||||
Issue descriptionChrome Version: dev build 58.0.3014.0 OS: Android Nexus 6p What steps will reproduce the problem? (1) Uninstall all updates to Google Vr Services in play store (2) Navigate to a page that calls navigator.getVRDisplays() (such as https://webvr.info/samples/03-vr-presentation.html) What is the expected result? Promise from getVRDisplays() should resolve with no devices (since Vr Services are out of date) What happens instead? The promise never resolves.
,
Feb 17 2017
,
Feb 17 2017
Clarifying comment #1. The issue does occur on official dev 58.0.3012.4 (and recent dev builds), but doesn't happen on earlier official versions of 57 or 56.
,
Feb 17 2017
Looks like this was caused by https://codereview.chromium.org/2658643003 which changed when devices where added by the GvrDeviceProvider. I have a potential fix up in https://codereview.chromium.org/2705653005/
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd47ba396451348cc15ecbc53255cb618e457414 commit dd47ba396451348cc15ecbc53255cb618e457414 Author: amp <amp@chromium.org> Date: Tue Feb 21 22:10:22 2017 Fix WebVR getDevices promise not resolving when VR Services are not compatible. Adds a check for initialization before GvrDeviceProvider adds a device. Adding a device without the library in place (succesful initialization) makes the promise hang waiting for a device connected event which never happens. BUG= 693298 Review-Url: https://codereview.chromium.org/2705653005 Cr-Commit-Position: refs/heads/master@{#451847} [modify] https://crrev.com/dd47ba396451348cc15ecbc53255cb618e457414/device/vr/android/gvr/gvr_device_provider.cc
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd47ba396451348cc15ecbc53255cb618e457414 commit dd47ba396451348cc15ecbc53255cb618e457414 Author: amp <amp@chromium.org> Date: Tue Feb 21 22:10:22 2017 Fix WebVR getDevices promise not resolving when VR Services are not compatible. Adds a check for initialization before GvrDeviceProvider adds a device. Adding a device without the library in place (succesful initialization) makes the promise hang waiting for a device connected event which never happens. BUG= 693298 Review-Url: https://codereview.chromium.org/2705653005 Cr-Commit-Position: refs/heads/master@{#451847} [modify] https://crrev.com/dd47ba396451348cc15ecbc53255cb618e457414/device/vr/android/gvr/gvr_device_provider.cc
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd47ba396451348cc15ecbc53255cb618e457414 commit dd47ba396451348cc15ecbc53255cb618e457414 Author: amp <amp@chromium.org> Date: Tue Feb 21 22:10:22 2017 Fix WebVR getDevices promise not resolving when VR Services are not compatible. Adds a check for initialization before GvrDeviceProvider adds a device. Adding a device without the library in place (succesful initialization) makes the promise hang waiting for a device connected event which never happens. BUG= 693298 Review-Url: https://codereview.chromium.org/2705653005 Cr-Commit-Position: refs/heads/master@{#451847} [modify] https://crrev.com/dd47ba396451348cc15ecbc53255cb618e457414/device/vr/android/gvr/gvr_device_provider.cc
,
Feb 21 2017
,
Mar 27 2017
,
Jul 4
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by amp@chromium.org
, Feb 17 2017