New issue
Advanced search Search tips

Issue 693288 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Reduce the number of empty media browser tests

Project Member Reported by xhw...@chromium.org, Feb 17 2017

Issue description

Today we are using parameterized tests in our media (content) browser tests. However, not all combinations of the parameters are supported. So we end up with something like this pattern in many of the tests:

IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, Foo) {
  if (!IsPlayBackPossible(GetParam())) {
    DVLOG(0) << "Skipping test.";
    return;
  }
  DoFooTest();
}

This works. However, every time the test will start the Chrome browser (or content shell), setting up everything and enter the test, only to find that the test is not supported and immediately return.

This added a lot of dummy tests, and would make test time much longer than necessary.

I think we should have some way to specify a blacklist of parameter combinations such that test cases for them will not be generated.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -xhw...@chromium.org
Owner: xhw...@chromium.org
Status: Assigned (was: Untriaged)
xhwang@, do you still want to keep this bug? if not, feel free to resolve it.

Sign in to add a comment