New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 693258 link

Starred by 1 user
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: [Workspace] cannot delete files in navigator

Project Member Reported by lushnikov@chromium.org, Feb 16 2017 
Chrome Version       : 56.0.2924.87

Steps:
1. Add a folder to devtools
2. Create a new file (works fine)
3. Try to delete a newly created file

Actual:
File gets removed from navigator, but remains on the FS

Expected:
I expect file to be removed




Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Comment 1 by lushnikov@chromium.org, Feb 17 2017

Status: Started (was: Assigned)
This seems to be regressed over a year ago: https://codereview.chromium.org/1564113003
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bdfccc8b18cf18642fc48056a7a58d07f01265a

commit 3bdfccc8b18cf18642fc48056a7a58d07f01265a
Author: lushnikov <lushnikov@chromium.org>
Date: Fri Feb 17 06:20:17 2017

DevTools: "Delete File" in navigator should actually delete a file

The IsolatedFileSystem failed to delete a file since it expects a relative
URL to be passed in.

BUG= 693258 
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2697403003
Cr-Commit-Position: refs/heads/master@{#451243}

[modify] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js
[add] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/filesystem-delete-file-expected.txt
[add] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/filesystem-delete-file.html
[modify] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html
[modify] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js
[modify] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
[modify] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
[modify] https://crrev.com/3bdfccc8b18cf18642fc48056a7a58d07f01265a/third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js

Comment 3 by lushnikov@chromium.org, Feb 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment