New issue
Advanced search Search tips

Issue 693256 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unnecessary upmixing layout tests

Project Member Reported by rtoy@chromium.org, Feb 16 2017 
The layout tests named up-mixing*.html should be removed because they're covered by AudioNode/audio-channel-rules.html which does everything these do and more.

Also remove stereo2mono-down-mixing.html because it tests that a stereo source to a mono context doesn't crash.  This, too, is covered by audio-channel-rules.html.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc8f880eb1ad53ca001981ebacd4569b91c61379

commit bc8f880eb1ad53ca001981ebacd4569b91c61379
Author: rtoy <rtoy@chromium.org>
Date: Fri Feb 24 23:10:38 2017

Remove up-mixing* and stereo2mono-down-mixing tests

These tests are covered by AudioNode/audionode-channel-rules.html
which is a much more complete test of the mixing rules.

stereo2mono-down-mixing was testing that a stereo source downmixed to
mono by the destination doesn't crash.  This is also covered by
audionode-channel-rules which tests downmixing of any channel
arrangements to a mono destination.

BUG= 693256 
TEST=none

Review-Url: https://codereview.chromium.org/2702763002
Cr-Commit-Position: refs/heads/master@{#452982}

[delete] https://crrev.com/3f6f704e1dd29f27151815af2b24e5da87711546/third_party/WebKit/LayoutTests/webaudio/stereo2mono-down-mixing-expected.txt
[delete] https://crrev.com/3f6f704e1dd29f27151815af2b24e5da87711546/third_party/WebKit/LayoutTests/webaudio/stereo2mono-down-mixing.html
[delete] https://crrev.com/3f6f704e1dd29f27151815af2b24e5da87711546/third_party/WebKit/LayoutTests/webaudio/up-mixing-mono-51-expected.wav
[delete] https://crrev.com/3f6f704e1dd29f27151815af2b24e5da87711546/third_party/WebKit/LayoutTests/webaudio/up-mixing-mono-51.html
[delete] https://crrev.com/3f6f704e1dd29f27151815af2b24e5da87711546/third_party/WebKit/LayoutTests/webaudio/up-mixing-mono-stereo-expected.wav
[delete] https://crrev.com/3f6f704e1dd29f27151815af2b24e5da87711546/third_party/WebKit/LayoutTests/webaudio/up-mixing-mono-stereo.html
[delete] https://crrev.com/3f6f704e1dd29f27151815af2b24e5da87711546/third_party/WebKit/LayoutTests/webaudio/up-mixing-stereo-51-expected.wav
[delete] https://crrev.com/3f6f704e1dd29f27151815af2b24e5da87711546/third_party/WebKit/LayoutTests/webaudio/up-mixing-stereo-51.html

Comment 2 by rtoy@chromium.org, Mar 6 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment