New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 693229 link

Starred by 1 user
Status: Fixed
Owner:
█ xlai@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
█ junov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Refactor sync token usage in TextureHolder subclasses

Project Member Reported by emir...@chromium.org, Feb 16 2017 
AcceleratedStaticBitmapImage::updateSyncToken() is defined an empty override of TextureHolder::updateSyncToken() as a workaround, see https://codereview.chromium.org/2632593003/#msg61. 

We should refactor TextureHolder and its subclasses so that AcceleratedStaticBitmapImage::imageForCurrentFrame() is not misused in the case when m_textureHolder is MailboxTextureHolder.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08583e375717564923404ed4b6fd6660ce259a97

commit 08583e375717564923404ed4b6fd6660ce259a97
Author: xlai <xlai@chromium.org>
Date: Mon Mar 13 16:57:21 2017

Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas commit

This is a follow-up CL of https://codereview.chromium.org/2632593003/.
This will make "WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames" not hit UNREACHED when it is enabled.

BUG= 693229 

Review-Url: https://codereview.chromium.org/2740003004
Cr-Commit-Position: refs/heads/master@{#456402}

[modify] https://crrev.com/08583e375717564923404ed4b6fd6660ce259a97/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
[modify] https://crrev.com/08583e375717564923404ed4b6fd6660ce259a97/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/08583e375717564923404ed4b6fd6660ce259a97/third_party/WebKit/Source/platform/graphics/SkiaTextureHolder.h

Comment 2 by xlai@chromium.org, Mar 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment