The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a37a3c270737739b63bca0dc46e7ee2e1d1ebdd4

commit a37a3c270737739b63bca0dc46e7ee2e1d1ebdd4
Author: scottchen <scottchen@chromium.org>
Date: Tue Feb 28 19:44:56 2017

MD Settings: add more extension controlled pref handling.

This previously existing code was removed earlier, but turns out to be necessary so adding the code back.

BUG= 693226 

Review-Url: https://codereview.chromium.org/2720503007
Cr-Commit-Position: refs/heads/master@{#453673}

[modify] https://crrev.com/a37a3c270737739b63bca0dc46e7ee2e1d1ebdd4/chrome/browser/extensions/api/settings_private/prefs_util.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8ee83729c29c767b7465dc23940b83a8a88fb89

commit d8ee83729c29c767b7465dc23940b83a8a88fb89
Author: scottchen <scottchen@chromium.org>
Date: Fri Mar 10 01:54:20 2017

MD Settings: add extension-control indicator for autofill and password.

BUG= 693226 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2733273002
Cr-Commit-Position: refs/heads/master@{#455956}

[modify] https://crrev.com/d8ee83729c29c767b7465dc23940b83a8a88fb89/chrome/browser/resources/settings/controls/settings_input.html
[modify] https://crrev.com/d8ee83729c29c767b7465dc23940b83a8a88fb89/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/d8ee83729c29c767b7465dc23940b83a8a88fb89/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/d8ee83729c29c767b7465dc23940b83a8a88fb89/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/d8ee83729c29c767b7465dc23940b83a8a88fb89/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/d8ee83729c29c767b7465dc23940b83a8a88fb89/chrome/test/data/webui/settings/settings_toggle_button_tests.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a3253c3dc5edc041db7f64cca32476181f09013

commit 4a3253c3dc5edc041db7f64cca32476181f09013
Author: dbeam <dbeam@chromium.org>
Date: Fri Mar 10 20:56:01 2017

MD Settings: defer sending pref updates until all synchronous operations finish

In the case of extension-controlled prefs, extensions like fillr use

  chrome.privacy.services.autofillEnabled.set({value: false});

To disable Chrome's native Autofill.

When this happens, code runs[1] in chrome to set a pref in the:

1) profile pref store
2) extensions pref store

We observe changes to the profile pref store.  So the order is:

1) set value in profile pref store
-> change happens
2) set value in extensions pref store

Unfortunately, we ask in the observer whether
pref->IsExtensionControlled()[2], which check which store the value comes from.

This will change on the next line of code, but isn't updated yet.

I considered just changing the order (which might be valid), but I think
asyncrifying potentially solves other types of observer order issues.

R=rdevlin.cronin@chromium.org
BUG= 693226 

[1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/preference/preference_api.cc?type=cs&q=passwordsavingenabled&l=448,446
[2] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/settings_private/prefs_util.cc?q=prefs_util.cc&sq=package:chromium&dr&l=486,751

Review-Url: https://codereview.chromium.org/2742663002
Cr-Commit-Position: refs/heads/master@{#456155}

[modify] https://crrev.com/4a3253c3dc5edc041db7f64cca32476181f09013/chrome/browser/extensions/api/settings_private/settings_private_event_router.cc
[modify] https://crrev.com/4a3253c3dc5edc041db7f64cca32476181f09013/chrome/browser/extensions/api/settings_private/settings_private_event_router.h