New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693222 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Profile chooser button is not highlighted when hovering over name

Project Member Reported by thomasanderson@chromium.org, Feb 16 2017

Issue description

Chrome Version: Chromium 58.0.3015.0
OS: Ubuntu 14.04

Please see the attached video.  The highlight is missing when hovering over the name or email.
 
highlight_broken.mp4
384 KB View Download
This video is after reverting https://codereview.chromium.org/2633183002
revert.mp4
1.8 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9823bcf8d6c7063484cdc8c7b1948a9735ace7a

commit f9823bcf8d6c7063484cdc8c7b1948a9735ace7a
Author: thomasanderson <thomasanderson@chromium.org>
Date: Fri Feb 17 05:05:52 2017

Revert of Linux/Windows: Remove NonInteractiveContainer from the profile chooser. (patchset #1 id:1 of https://codereview.chromium.org/2633183002/ )

Reason for revert:
Broke button highlight when hovering over name or email labels.  See  crbug.com/693222 

Original issue's description:
> Linux/Windows: Remove NonInteractiveContainer from the profile chooser.
>
> This CL replaces the NonInteractiveContainer class by a View class. The only
> goal from NonInteractiveContainer was to return false from
> CanProcessEventsWithinSubtree().
>
> This view only contains a Label which has no interaction with the mouse. The
> only difference is enabling tool tips.
>
> BUG= 674462 
>
> Review-Url: https://codereview.chromium.org/2633183002
> Cr-Commit-Position: refs/heads/master@{#448228}
> Committed: https://chromium.googlesource.com/chromium/src/+/bce01de43097d69f127f2637d9c3398ff780462a

TBR=msarda@chromium.org,rogerta@chromium.org,pkasting@chromium.org,jlebel@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 674462 , 693222 

Review-Url: https://codereview.chromium.org/2701693003
Cr-Commit-Position: refs/heads/master@{#451222}

[modify] https://crrev.com/f9823bcf8d6c7063484cdc8c7b1948a9735ace7a/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Status: Fixed (was: Started)

Comment 4 by jlebel@chromium.org, Feb 20 2017

Cc: durga.behera@chromium.org ranjitkan@chromium.org jlebel@chromium.org nyerramilli@chromium.org msrchandra@chromium.org ajha@chromium.org kavvaru@chromium.org brajkumar@chromium.org hdodda@chromium.org
 Issue 689867  has been merged into this issue.

Sign in to add a comment