Issue metadata
Sign in to add a comment
|
http://www.apple.com/macos/sierra/ renders incorrectly on high-DPI displays (e.g. Retina MacBook Pros) |
||||||||||||||||||||||
Issue descriptionChrome Version: 58.0.3006.0 (Official Build) canary (64-bit) OS: macOS 10.12.2 What steps will reproduce the problem? (1) Navigate to http://www.apple.com/macos/sierra/ (2) Scroll down What is the expected result? Expect zoom-in animation to render correctly. What happens instead? It's clipped incorrectly. The device scale factor must be being applied incorrectly somewhere along the chain. This is a regression of Issue 644582 .
,
Feb 16 2017
,
Feb 17 2017
Bisect points to https://chromium.googlesource.com/chromium/src/+/2ef7df4c03595db39c1b0c303ec8a822f0bf30c9 , the same CL that caused the other similar bug ( crbug.com/644582 ), will investigate further.
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/264a0dd42bb8612ab0d2d60645e722a7758b013e commit 264a0dd42bb8612ab0d2d60645e722a7758b013e Author: jaydasika <jaydasika@chromium.org> Date: Fri Feb 24 23:17:27 2017 cc : Fix transform calculation bug while calculating clip rects The bug is while calculating the transform from a clip parent's target to clip child's target. We weren't taking into account the surface contents scale at both targets. This CL fixes that. Also verified that the new clip rects path (which is behind a flag) doesn't have this bug, we do the correct scaling there already. BUG= 693213 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2712053002 Cr-Commit-Position: refs/heads/master@{#452987} [modify] https://crrev.com/264a0dd42bb8612ab0d2d60645e722a7758b013e/cc/trees/draw_property_utils.cc [modify] https://crrev.com/264a0dd42bb8612ab0d2d60645e722a7758b013e/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/264a0dd42bb8612ab0d2d60645e722a7758b013e/cc/trees/property_tree.cc [modify] https://crrev.com/264a0dd42bb8612ab0d2d60645e722a7758b013e/cc/trees/property_tree.h
,
Feb 27 2017
,
Feb 27 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc9450f1ad81cda200b6c1a42a2348d80753a0d6 commit cc9450f1ad81cda200b6c1a42a2348d80753a0d6 Author: Jayadev Dasika <jaydasika@google.com> Date: Tue Feb 28 00:59:13 2017 cc : Fix transform calculation bug while calculating clip rects The bug is while calculating the transform from a clip parent's target to clip child's target. We weren't taking into account the surface contents scale at both targets. This CL fixes that. Also verified that the new clip rects path (which is behind a flag) doesn't have this bug, we do the correct scaling there already. BUG= 693213 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2712053002 Cr-Commit-Position: refs/heads/master@{#452987} (cherry picked from commit 264a0dd42bb8612ab0d2d60645e722a7758b013e) Review-Url: https://codereview.chromium.org/2715243008 . Cr-Commit-Position: refs/branch-heads/2987@{#709} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/cc9450f1ad81cda200b6c1a42a2348d80753a0d6/cc/trees/draw_property_utils.cc [modify] https://crrev.com/cc9450f1ad81cda200b6c1a42a2348d80753a0d6/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/cc9450f1ad81cda200b6c1a42a2348d80753a0d6/cc/trees/property_tree.cc [modify] https://crrev.com/cc9450f1ad81cda200b6c1a42a2348d80753a0d6/cc/trees/property_tree.h
,
Feb 28 2017
,
Mar 1 2017
Rechecked this issue on chrome beta version 57.0.2987.88 on MacBook Pro (Retina, Mid 2012). Navigated to website http://www.apple.com/macos/sierra/ and scrolled down. Zoom in animation is rendered correctly, attached a screenshot for the same. Adding TE-Verified labels. Thanks.! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Feb 16 2017