New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 693210 link

Starred by 1 user
Status: Verified
Owner:
█ sha...@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
█ rspangler@chromium.org
█ sha...@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec: Drop EC_CMD_VBNV_CONTEXT support when unneeded

Project Member Reported by sha...@chromium.org, Feb 16 2017 
Many platforms don't keep VB NVRAM on the EC, yet we always include support for EC_CMD_VBNV_CONTEXT. There are RAM / flash savings to be had.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/6ba124a81bd6d5af1edae5f30add22e81b8b7de7

commit 6ba124a81bd6d5af1edae5f30add22e81b8b7de7
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Sun Feb 26 00:34:15 2017

hostcmd: Remove EC_CMD_VBNV_CONTEXT handler for most boards

Most boards do not keep VBNV storage on the EC, so leave out the host
command handler by default.

BUG= chromium:693210 
BRANCH=None
TEST=`make buildall -j`

Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: Ia202ec7d73d1804d8430fe7516cc783afd86e89a
Reviewed-on: https://chromium-review.googlesource.com/446716
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>

[modify] https://crrev.com/6ba124a81bd6d5af1edae5f30add22e81b8b7de7/board/pit/board.h
[modify] https://crrev.com/6ba124a81bd6d5af1edae5f30add22e81b8b7de7/include/system.h
[modify] https://crrev.com/6ba124a81bd6d5af1edae5f30add22e81b8b7de7/common/system.c
[modify] https://crrev.com/6ba124a81bd6d5af1edae5f30add22e81b8b7de7/include/config.h
[modify] https://crrev.com/6ba124a81bd6d5af1edae5f30add22e81b8b7de7/board/jerry/board.h
[modify] https://crrev.com/6ba124a81bd6d5af1edae5f30add22e81b8b7de7/board/big/board.h

Comment 2 by gkihumba@google.com, Mar 31 2017

Owner: sha...@chromium.org
Status: Assigned (was: Untriaged)
Should we close this?

Comment 3 by sha...@chromium.org, Jun 13 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment