New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 693194 link

Starred by 1 user
Status: WontFix
Owner:
█ mfomitchev@chromium.org
inactive
Closed: Feb 2017
Cc:
█ thanhph@chromium.org
msw@chromium.org
█ mfomitchev@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

mustash: ServerWindows not destroyed when closing app list

Project Member Reported by kylec...@chromium.org, Feb 16 2017 
When the app list is opened a hierarchy of 5 ServerWindows is created. When the app list is closed only the top four ServerWindows are destroyed. The ServerWindow at the deepest part of the hierarchy is not destroyed and gets reused next time the app list is opened.

The ServerWindow that isn't destroyed has a CompositorFrameSink associated with it. There will be some GPU resources associated with the CompositorFrameSink aren't going to be freed as a result.

Comment 1 by mfomitchev@chromium.org, Feb 16 2017

Cc: msw@chromium.org thanhph@chromium.org
Components: Internals>MUS UI>Shell>Launcher
Labels: mustash-1 Proj-Mustash-Mash
Owner: mfomitchev@chromium.org
+msw, thanhph FYI
Assigning to myself, will take a look soon unless somebody else wants this one :)

Slapping mustash-1 on it, since it seems like we should at least investigate to understand what's going on.

Comment 2 by xiy...@chromium.org, Feb 16 2017 

I suspect the remaining one is for the WebContents used for StartPageView [1].

[1]: https://cs.chromium.org/chromium/src/ui/app_list/views/start_page_view.cc?rcl=db42b5a4025c3ae2402efe7307fc34aee119487d&l=318

Comment 3 by mfomitchev@chromium.org, Feb 16 2017 

Shouldn't it go away when the app list is dismissed? Is there some singleton that's left hanging around? And if so - is it an okay behavior?

Comment 4 by xiy...@chromium.org, Feb 16 2017 

The WebContents is created with user profile (in StartPageService PKS) [1]. It was kept around so that app list can show up fast. Creating a WebContents from scratch takes ~100ms, which is too slow. 

[1]: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/start_page_service.cc?rcl=db42b5a4025c3ae2402efe7307fc34aee119487d&l=382

Comment 5 by mfomitchev@chromium.org, Feb 16 2017 

Thanks Xiyuan! Kyle, can you confirm that you only saw the 'new' ServerWindow created (and left around) on the first launch, but not on the subsequent app list launches? If yes, I think we can close this as 'working as intended'.

Comment 6 by kylec...@chromium.org, Feb 16 2017

Status: WontFix (was: Available)
Yep, only the first launch. Sounds like WAI then.

Comment 7 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService
►

Sign in to add a comment